fix(spanner): release resources in TransactionManager #3638
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
product-auto-label
bot
added
size: s
olavloite
approved these changes
Feb 13, 2025
| @@ -80,6 +80,13 @@ public void commit() { | |||
| } catch (SpannerException e2) { | |||
| txnState = TransactionState.COMMIT_FAILED; | |||
| throw e2; | |||
| } finally { | |||
| // At this point, if the TransactionState is not ABORTED, then the transaction has reached a | |||
| // terminal state. | |||
There was a problem hiding this comment.
super-nit: I would recommend using end state instead of terminal state.
There was a problem hiding this comment.
sure, I have used this term from existing code. But end state is more clear in terms of readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
close()method inTransactionManagerwas only being called when used within atry-with-resourcesblock, asTransactionManagerimplementsAutoCloseable.However, in cases where
try-with-resourceswas not used or.close()was not explicitly called,close()was never invoked, leading to resource leaks—such as spans not being closed properly. This is particularly an issue in JDBC, wheretry-with-resourcescannot be used.This PR ensures that
close()is implicitly invoked whenever the transaction reaches an end state, preventing resource leaks.