fix: multiplexed session metrics were not included in refactor move #3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metrics for multiplexed sessions were not included in the refactoring that moved multiplexed sessions out of the session pool. This change re-adds those metrics based on the new client for multiplexed sessions.
product-auto-label
bot
added
size: m
olavloite
commented
May 3, 2024
| @@ -3143,7 +3153,7 @@ boolean isValid() { | |||
|
|
|||
| /** | |||
| * Returns a multiplexed session. The method fallbacks to a regular session if {@link | |||
| * SessionPoolOptions#useMultiplexedSession} is not set. | |||
| * SessionPoolOptions#getUseMultiplexedSession} is not set. | |||
There was a problem hiding this comment.
This reference was wrong, and showed up as a warning in IntelliJ
olavloite
commented
May 3, 2024
| @@ -68,7 +68,6 @@ | |||
| import com.google.common.base.Function; | |||
| import com.google.common.base.MoreObjects; | |||
| import com.google.common.base.Preconditions; | |||
| import com.google.common.base.Supplier; | |||
There was a problem hiding this comment.
This is not directly related to this change, but we should start to replace the use of com.google.common.base.Supplier with java.util.function.Supplier.
olavloite
commented
May 3, 2024
| @@ -555,28 +551,6 @@ public void clearRequests() { | |||
| mockSpanner.clearRequests(); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testCounter() throws InterruptedException { | |||
There was a problem hiding this comment.
This test was committed in a previous PR by accident. It was only intended as a test to verify that increasing an AtomicInteger does not introduce any noticeable lock contention.
rahul2393
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metrics for multiplexed sessions were not included in the refactoring that moved multiplexed sessions out of the session pool. This change re-adds those metrics based on the new client for multiplexed sessions.