From c370f35f8444cc60bcc8640fa310bdfb516f7227 Mon Sep 17 00:00:00 2001 From: Astha Mohta Date: Mon, 4 Apr 2022 12:06:37 +0530 Subject: [PATCH] linting --- .../com/example/spanner/CopyBackupSample.java | 151 +++++++++--------- .../com/example/spanner/SpannerSample.java | 60 +++---- 2 files changed, 106 insertions(+), 105 deletions(-) diff --git a/samples/snippets/src/main/java/com/example/spanner/CopyBackupSample.java b/samples/snippets/src/main/java/com/example/spanner/CopyBackupSample.java index c76f752af03..e8c4000532e 100644 --- a/samples/snippets/src/main/java/com/example/spanner/CopyBackupSample.java +++ b/samples/snippets/src/main/java/com/example/spanner/CopyBackupSample.java @@ -34,90 +34,87 @@ import java.util.concurrent.TimeUnit; public class CopyBackupSample { - - public static void main(String[] args) { - if (args.length != 4) { - throw new IllegalArgumentException( - "Invalid number of arguments. " - + "Usage: CopyBackupSample " - + " "); - } - String projectId = args[0]; - String instanceId = args[1]; - String sourceBackupId = args[2]; - String destinationBackupId = args[3]; - - try (Spanner spanner = - SpannerOptions.newBuilder().setProjectId(projectId).build().getService()) { - DatabaseAdminClient databaseAdminClient = spanner.getDatabaseAdminClient(); - copyBackup(databaseAdminClient, projectId, instanceId, sourceBackupId, destinationBackupId); - } + public static void main(String[] args) { + if (args.length != 4) { + throw new IllegalArgumentException( + "Invalid number of arguments. " + + "Usage: CopyBackupSample " + + " "); } + String projectId = args[0]; + String instanceId = args[1]; + String sourceBackupId = args[2]; + String destinationBackupId = args[3]; - static void copyBackup() { - // TODO(developer): Replace these variables before running the sample. - String projectId = "my-project"; - String instanceId = "my-instance"; - String sourceBackupId = "my-backup"; - String destinationBackupId = "my-destination-backup"; - - try (Spanner spanner = - SpannerOptions.newBuilder().setProjectId(projectId).build().getService()) { - DatabaseAdminClient databaseAdminClient = spanner.getDatabaseAdminClient(); - copyBackup(databaseAdminClient, projectId, instanceId, sourceBackupId, destinationBackupId); - } + try (Spanner spanner = + SpannerOptions.newBuilder().setProjectId(projectId).build().getService()) { + DatabaseAdminClient databaseAdminClient = spanner.getDatabaseAdminClient(); + copyBackup(databaseAdminClient, projectId, instanceId, sourceBackupId, destinationBackupId); } + } - static Void copyBackup( - DatabaseAdminClient databaseAdminClient, - String projectId, - String instanceId, - String sourceBackupId, - String destinationBackupId) { - - Timestamp expireTime = - Timestamp.ofTimeMicroseconds( - TimeUnit.MICROSECONDS.convert( - System.currentTimeMillis() + TimeUnit.DAYS.toMillis(14), TimeUnit.MILLISECONDS)); - // Creates a copy of an existing backup. - Backup destinationBackup = - databaseAdminClient - .newBackupBuilder(BackupId.of(projectId, instanceId, destinationBackupId)) - .setExpireTime(expireTime) - .build(); + static void copyBackup() { + // TODO(developer): Replace these variables before running the sample. + String projectId = "my-project"; + String instanceId = "my-instance"; + String sourceBackupId = "my-backup"; + String destinationBackupId = "my-destination-backup"; + try (Spanner spanner = + SpannerOptions.newBuilder().setProjectId(projectId).build().getService()) { + DatabaseAdminClient databaseAdminClient = spanner.getDatabaseAdminClient(); + copyBackup(databaseAdminClient, projectId, instanceId, sourceBackupId, destinationBackupId); + } + } - // Initiate the request which returns an OperationFuture. - System.out.println("Copying backup [" + destinationBackup.getId() + "]..."); - OperationFuture op = - databaseAdminClient.copyBackup( - BackupId.of(projectId, instanceId, sourceBackupId), destinationBackup); - try { - // Wait for the backup operation to complete. - destinationBackup = op.get(); - System.out.println("Copied backup [" + destinationBackup.getId() + "]"); - } catch (ExecutionException e) { - throw (SpannerException) e.getCause(); - } catch (InterruptedException e) { - throw SpannerExceptionFactory.propagateInterrupt(e); - } + static Void copyBackup( + DatabaseAdminClient databaseAdminClient, + String projectId, + String instanceId, + String sourceBackupId, + String destinationBackupId) { - // Reload the metadata of the backup from the server. - destinationBackup = destinationBackup.reload(); - System.out.println( - String.format( - "Backup %s of size %d bytes was copied at %s for version of database at %s", - destinationBackup.getId().getName(), - destinationBackup.getSize(), - LocalDateTime.ofEpochSecond( - destinationBackup.getProto().getCreateTime().getSeconds(), - destinationBackup.getProto().getCreateTime().getNanos(), - OffsetDateTime.now().getOffset()), - LocalDateTime.ofEpochSecond( - destinationBackup.getProto().getVersionTime().getSeconds(), - destinationBackup.getProto().getVersionTime().getNanos(), - OffsetDateTime.now().getOffset()))); + Timestamp expireTime = + Timestamp.ofTimeMicroseconds( + TimeUnit.MICROSECONDS.convert( + System.currentTimeMillis() + TimeUnit.DAYS.toMillis(14), + TimeUnit.MILLISECONDS)); + // Creates a copy of an existing backup. + Backup destinationBackup = + databaseAdminClient + .newBackupBuilder(BackupId.of(projectId, instanceId, destinationBackupId)) + .setExpireTime(expireTime) + .build(); - return null; + // Initiate the request which returns an OperationFuture. + System.out.println("Copying backup [" + destinationBackup.getId() + "]..."); + OperationFuture op = + databaseAdminClient.copyBackup( + BackupId.of(projectId, instanceId, sourceBackupId), destinationBackup); + try { + // Wait for the backup operation to complete. + destinationBackup = op.get(); + System.out.println("Copied backup [" + destinationBackup.getId() + "]"); + } catch (ExecutionException e) { + throw (SpannerException) e.getCause(); + } catch (InterruptedException e) { + throw SpannerExceptionFactory.propagateInterrupt(e); } + // Reload the metadata of the backup from the server. + destinationBackup = destinationBackup.reload(); + System.out.println( + String.format( + "Backup %s of size %d bytes was copied at %s for version of database at %s", + destinationBackup.getId().getName(), + destinationBackup.getSize(), + LocalDateTime.ofEpochSecond( + destinationBackup.getProto().getCreateTime().getSeconds(), + destinationBackup.getProto().getCreateTime().getNanos(), + OffsetDateTime.now().getOffset()), + LocalDateTime.ofEpochSecond( + destinationBackup.getProto().getVersionTime().getSeconds(), + destinationBackup.getProto().getVersionTime().getNanos(), + OffsetDateTime.now().getOffset()))); + return null; + } } // [END spanner_copy_backup] diff --git a/samples/snippets/src/main/java/com/example/spanner/SpannerSample.java b/samples/snippets/src/main/java/com/example/spanner/SpannerSample.java index 46952bf29d6..1d4055b95be 100644 --- a/samples/snippets/src/main/java/com/example/spanner/SpannerSample.java +++ b/samples/snippets/src/main/java/com/example/spanner/SpannerSample.java @@ -56,8 +56,8 @@ import com.google.common.io.BaseEncoding; import com.google.longrunning.Operation; import com.google.protobuf.InvalidProtocolBufferException; -import com.google.spanner.admin.database.v1.CreateBackupMetadata; import com.google.spanner.admin.database.v1.CopyBackupMetadata; +import com.google.spanner.admin.database.v1.CreateBackupMetadata; import com.google.spanner.admin.database.v1.CreateDatabaseMetadata; import com.google.spanner.admin.database.v1.OptimizeRestoredDatabaseMetadata; import com.google.spanner.admin.database.v1.RestoreDatabaseMetadata; @@ -1669,12 +1669,14 @@ static void listBackupOperations( TimeUnit.HOURS), 0); String filter = String.format( - "(metadata.@type:type.googleapis.com/google.spanner.admin.database.v1.CreateBackupMetadata) " + "(metadata.@type:type.googleapis.com/" + + "google.spanner.admin.database.v1.CreateBackupMetadata) " + "AND (metadata.database:%s)", databaseId.getName()); - Page createBackupOperations = instance.listBackupOperations(Options.filter(filter)); - System.out.println("Create Backup Operations:"); - for (Operation op : createBackupOperations.iterateAll()) { + Page createBackupOperations = instance.listBackupOperations( + Options.filter(filter)); + System.out.println("Create Backup Operations:"); + for (Operation op : createBackupOperations.iterateAll()) { try { CreateBackupMetadata metadata = op.getMetadata().unpack(CreateBackupMetadata.class); System.out.println( @@ -1688,29 +1690,30 @@ static void listBackupOperations( System.err.println(e.getMessage()); } } - // Get copy backup operations for the sample database. - filter = + // Get copy backup operations for the sample database. + filter = String.format( "(metadata.@type:type.googleapis.com/" + "google.spanner.admin.database.v1.CopyBackupMetadata) " + "AND (metadata.source_backup:%s)", backupId.getName()); - Page copyBackupOperations = instance.listBackupOperations(Options.filter(filter)); - System.out.println("Copy Backup Operations:"); - for (Operation op : copyBackupOperations.iterateAll()) { - try { - CopyBackupMetadata copyBackupMetadata = op.getMetadata().unpack(CopyBackupMetadata.class); - System.out.println( + Page copyBackupOperations = instance.listBackupOperations(Options.filter(filter)); + System.out.println("Copy Backup Operations:"); + for (Operation op : copyBackupOperations.iterateAll()) { + try { + CopyBackupMetadata copyBackupMetadata = + op.getMetadata().unpack(CopyBackupMetadata.class); + System.out.println( String.format( "Copy Backup %s on backup %s pending: %d%% complete", copyBackupMetadata.getName(), copyBackupMetadata.getSourceBackup(), copyBackupMetadata.getProgress().getProgressPercent())); - } catch (InvalidProtocolBufferException e) { - // The returned operation does not contain CopyBackupMetadata. - System.err.println(e.getMessage()); - } + } catch (InvalidProtocolBufferException e) { + // The returned operation does not contain CopyBackupMetadata. + System.err.println(e.getMessage()); } + } } // [END spanner_list_backup_operations] @@ -1864,18 +1867,19 @@ static void updateBackup(DatabaseAdminClient dbAdminClient, BackupId backupId) { TimeUnit.SECONDS.toMicros(backup.getExpireTime().getSeconds()) + TimeUnit.NANOSECONDS.toMicros(backup.getExpireTime().getNanos()) + TimeUnit.DAYS.toMicros(30L)); - // New Expire Time must be less than Max Expire Time - expireTime = expireTime.compareTo(backup.getMaxExpireTime())<0?expireTime:backup.getMaxExpireTime(); - int timeDiff = expireTime.compareTo(backup.getExpireTime()); - Timestamp newExpireTime = (timeDiff < 0) ? expireTime : backup.getExpireTime(); + // New Expire Time must be less than Max Expire Time + expireTime = expireTime.compareTo(backup.getMaxExpireTime()) + < 0 ? expireTime : backup.getMaxExpireTime(); + int timeDiff = expireTime.compareTo(backup.getExpireTime()); + Timestamp newExpireTime = (timeDiff < 0) ? expireTime : backup.getExpireTime(); - System.out.println(String.format( + System.out.println(String.format( "Updating expire time of backup [%s] to %s...", backupId.toString(), LocalDateTime.ofEpochSecond( - expireTime.getSeconds(), - expireTime.getNanos(), - OffsetDateTime.now().getOffset()).toString())); + expireTime.getSeconds(), + expireTime.getNanos(), + OffsetDateTime.now().getOffset()).toString())); // Update expire time. backup = backup.toBuilder().setExpireTime(expireTime).build(); @@ -2180,7 +2184,7 @@ static void printUsageAndExit() { } public static void main(String[] args) throws Exception { - if (args.length != 3 && args.length != 4) { + if (args.length != 3 && args.length != 4) { printUsageAndExit(); } // [START init_client] @@ -2205,8 +2209,8 @@ public static void main(String[] args) throws Exception { "%s_%02d", db.getDatabase(), LocalDate.now().get(ChronoField.ALIGNED_WEEK_OF_YEAR)); BackupId backup = BackupId.of(db.getInstanceId(), backupName); - if( args.length == 4) { - backupName = args[3]; + if (args.length == 4) { + backupName = args[3]; } // [START init_client]