Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exactly Once Delivery Receipt Modacks #1523

Closed
maitrimangal opened this issue Mar 14, 2023 · 0 comments · Fixed by #1540
Closed

Exactly Once Delivery Receipt Modacks #1523

maitrimangal opened this issue Mar 14, 2023 · 0 comments · Fixed by #1540
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@maitrimangal
Copy link
Member

Need to change the client library for reciept modacks using the following logic:

  1. Client library receives a message from the service on streaming pull (already happens)
  2. Client library issues the first modack (aka receipt modack) as soon as a message is received (already happens)
  3. Client library waits for this modack (receipt modack) to succeed before sending the message to the user via callback.
    This is new
    Until now, IIUC, the modack will be executed asynchronously and the message will be sent to the user via callback.
    If the modack fails with temporary error, retry it
    If the modack fails with a permanent error, don't log it and move on.
  4. If the message is sent to the user via callback, client library extends the lease periodically by executing modack calls (already happens, no change needed)
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Mar 14, 2023
@maitrimangal maitrimangal mentioned this issue Apr 3, 2023
4 tasks
@maitrimangal maitrimangal added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant