Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding a maximum metadata size when creating the subscriber #1061

Merged
merged 1 commit into from
Mar 22, 2022
Merged

fix: adding a maximum metadata size when creating the subscriber #1061

merged 1 commit into from
Mar 22, 2022

Conversation

mmicatka
Copy link
Contributor

@mmicatka mmicatka commented Mar 21, 2022

There is a risk of crashing due to large metadata components of grpc responses when exactly once delivery is enabled. The metadata contains the ack-ids with responses statuses to indicate ack failures. The metadata size is set on the server-side to be a max of 4 MB which should be reflected on the client-side.

@mmicatka mmicatka requested a review from a team as a code owner March 21, 2022 19:08
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Mar 21, 2022
Copy link

@pradn pradn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mmicatka mmicatka added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 22, 2022
@mmicatka mmicatka merged commit 3a8c83b into googleapis:main Mar 22, 2022
@mmicatka mmicatka deleted the increase_max_metadata_size_limit branch March 22, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants