Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add RetryCallable to the callable chain #2348

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Sep 20, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mutianf mutianf requested review from a team as code owners September 20, 2024 17:33
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Sep 20, 2024
@mutianf mutianf changed the title fix: add StreamingAttemptCallable to the callable chain fix: add RetryCallable to the callable chain Sep 20, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Sep 20, 2024
// TODO resumption strategy and retry settings
.build();

ServerStreamingCallable<ExecuteQueryCallContext, SqlRow> retries =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you put a comment noting that this is just for client side metrics and we don't want any retries to happen right now?

@mutianf mutianf merged commit 0330d77 into googleapis:main Sep 24, 2024
20 of 21 checks passed
@mutianf mutianf deleted the retry-callable branch September 24, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants