Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add test proxy to java-bigtable client #1498

Merged
merged 9 commits into from
Nov 14, 2022
Merged

feat: add test proxy to java-bigtable client #1498

merged 9 commits into from
Nov 14, 2022

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Nov 7, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mutianf mutianf requested review from a team as code owners November 7, 2022 14:57
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Nov 7, 2022
igorbernstein2
igorbernstein2 reviewed Nov 7, 2022
View reviewed changes
test-proxy/pom.xml Show resolved Hide resolved
test-proxy/pom.xml Outdated Show resolved Hide resolved
test-proxy/pom.xml Show resolved Hide resolved
test-proxy/pom.xml Outdated Show resolved Hide resolved
test-proxy/pom.xml Outdated
<version>3.2.4</version>
<executions>
<execution>
<phase>package</phase>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this need to be shaded?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To specify the main class to start the proxy I think?

Copy link
Contributor

@igorbernstein2 igorbernstein2 Nov 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main entry point in the jar can be specified to make it executable:
https://maven.apache.org/shared/maven-archiver/examples/classpath.html#Make

Shading will produce a single jar thats executable. There is no readme here so I'm not sure how this is going to be executed. So I'll list a couple of approaches:

  1. Having a bash script that will mvn exec:java the proxy and then start the test suite
  2. Have a junit wrapper that starts the proxy at the beginning of the test run and then exec's the test suite

In both cases, we don't need to bundle the dependencies. In fact, bundling the deps prevents us from running the proxy with older clients. Which is primary advantage to having it as a separate artifact

test-proxy/src/main/java/com/google/cloud/bigtable/testproxy/CbtTestProxy.java Outdated Show resolved Hide resolved
test-proxy/src/main/java/com/google/cloud/bigtable/testproxy/CbtTestProxy.java Outdated Show resolved Hide resolved
test-proxy/src/main/java/com/google/cloud/bigtable/testproxy/CbtTestProxy.java Outdated Show resolved Hide resolved
test-proxy/src/main/java/com/google/cloud/bigtable/testproxy/CbtTestProxyMain.java Outdated Show resolved Hide resolved
test-proxy/src/main/java/com/google/cloud/bigtable/testproxy/CbtTestProxyMain.java Outdated Show resolved Hide resolved
kolea2
kolea2 suggested changes Nov 7, 2022
View reviewed changes
test-proxy/pom.xml Outdated Show resolved Hide resolved
liujiongxin
liujiongxin reviewed Nov 7, 2022
View reviewed changes
Copy link
Contributor

@liujiongxin liujiongxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall look good to me! Thanks for the effort!

test-proxy/pom.xml Show resolved Hide resolved
liujiongxin
liujiongxin reviewed Nov 8, 2022
View reviewed changes
Copy link
Contributor

@liujiongxin liujiongxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A readme file will be very helpful.

Example: https://github.com/googleapis/google-cloud-go/tree/main/bigtable/internal/testproxy, https://github.com/dbolduc/google-cloud-cpp/tree/cbt-test-proxy-dev-flattened/google/cloud/bigtable/cbt_test_proxy

mutianf
mutianf commented Nov 11, 2022
View reviewed changes
test-proxy/pom.xml Outdated
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-deploy-plugin</artifactId>
<version>3.0.0-M2</version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably don't need this version

mutianf
mutianf commented Nov 11, 2022
View reviewed changes
test-proxy/pom.xml Outdated
<parent>
<artifactId>google-cloud-bigtable-parent</artifactId>
<groupId>com.google.cloud</groupId>
<version>2.15.1-SNAPSHOT</version><!-- {x-version-update:google-cloud-bigtable:current} -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the parent version since we cut a new release

@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 12, 2022
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 12, 2022
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 12, 2022
kolea2
kolea2 approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one small comment

test-proxy/README.md Outdated Show resolved Hide resolved
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 14, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 14, 2022
@mutianf mutianf merged commit 132b4e4 into googleapis:main Nov 14, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 14, 2022
@mutianf mutianf deleted the test-proxy branch November 14, 2022 22:03
@release-please release-please bot mentioned this pull request Nov 14, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 7, 2022
@release-please
chore(main): release 2.17.0 (#1516)
2f0825e 
🤖 I have created a release *beep* *boop*
---


## [2.17.0](https://togithub.com/googleapis/java-bigtable/compare/v2.16.0...v2.17.0) (2022-12-07)


### Features

* Add a query paginator ([#1530](https://togithub.com/googleapis/java-bigtable/issues/1530)) ([5c8e1f6](https://togithub.com/googleapis/java-bigtable/commit/5c8e1f656b15177ecef4709b9e502cef58cca479))
* Add test proxy to java-bigtable client ([#1498](https://togithub.com/googleapis/java-bigtable/issues/1498)) ([132b4e4](https://togithub.com/googleapis/java-bigtable/commit/132b4e4fe340ca316de8eef2e2133b6dabd9dec3))
* Implement cross-project table restore ([#1536](https://togithub.com/googleapis/java-bigtable/issues/1536)) ([335977c](https://togithub.com/googleapis/java-bigtable/commit/335977c499b1776c8fa861d13195ffc49e468e0a))
* Next release from main branch is 2.17.0 ([#1514](https://togithub.com/googleapis/java-bigtable/issues/1514)) ([4fc6a93](https://togithub.com/googleapis/java-bigtable/commit/4fc6a93a25362df7bc107d48f94e1c00b6bd608d))


### Dependencies

* Update dependency com.google.cloud:google-cloud-monitoring-bom … ([#1531](https://togithub.com/googleapis/java-bigtable/issues/1531)) ([ee98338](https://togithub.com/googleapis/java-bigtable/commit/ee9833835a84cee202b142950b28704db682ac0c))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.0 ([#1539](https://togithub.com/googleapis/java-bigtable/issues/1539)) ([3244cef](https://togithub.com/googleapis/java-bigtable/commit/3244cefd4d77a44bab6ccaa8f5c03e3d31575625))
* Update dependency kr.motd.maven:os-maven-plugin to v1.7.1 ([#1518](https://togithub.com/googleapis/java-bigtable/issues/1518)) ([8309681](https://togithub.com/googleapis/java-bigtable/commit/830968109a3754a12bd0bc92674fe42ae529b924))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.19 ([#1537](https://togithub.com/googleapis/java-bigtable/issues/1537)) ([7f7c478](https://togithub.com/googleapis/java-bigtable/commit/7f7c478a2163c46d10ed39ea3c1b046f971d4569))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.19 ([#1538](https://togithub.com/googleapis/java-bigtable/issues/1538)) ([9d3df57](https://togithub.com/googleapis/java-bigtable/commit/9d3df57d7bfeafd9cbcf56ecd58b52cc1b14ba7b))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liujiongxin liujiongxin liujiongxin left review comments

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

@kolea2 kolea2 kolea2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mutianf @liujiongxin @igorbernstein2 @kolea2