From da703db25f6702b263dbd8ded0cb0fd3422efe31 Mon Sep 17 00:00:00 2001 From: Lawrence Qiu Date: Mon, 10 Jun 2024 21:00:33 +0000 Subject: [PATCH] fix: Add getServiceName() to EnhancedBigTableStubSettings (#2256) Adds a duplicate `getServiceName()` implementation to EnhancedBigTableStubSettings. This is similar to https://togithub.com/googleapis/java-bigtable/blob/de639bc7869dc5a25029367b8fc470fcd089667d/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableStubSettings.java#L171-L174, but is re-implemented as EnhancedBigTableStubSettings does not implement BigtableStubSettings --- README.md | 6 +++--- .../bigtable/data/v2/stub/EnhancedBigtableStubSettings.java | 5 +++++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 90aa37ffe7..888491c377 100644 --- a/README.md +++ b/README.md @@ -57,13 +57,13 @@ implementation 'com.google.cloud:google-cloud-bigtable' If you are using Gradle without BOM, add this to your dependencies: ```Groovy -implementation 'com.google.cloud:google-cloud-bigtable:2.39.4' +implementation 'com.google.cloud:google-cloud-bigtable:2.39.5' ``` If you are using SBT, add this to your dependencies: ```Scala -libraryDependencies += "com.google.cloud" % "google-cloud-bigtable" % "2.39.4" +libraryDependencies += "com.google.cloud" % "google-cloud-bigtable" % "2.39.5" ``` @@ -542,7 +542,7 @@ Java is a registered trademark of Oracle and/or its affiliates. [kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-bigtable/java11.html [stability-image]: https://img.shields.io/badge/stability-stable-green [maven-version-image]: https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-bigtable.svg -[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-bigtable/2.39.4 +[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-bigtable/2.39.5 [authentication]: https://github.com/googleapis/google-cloud-java#authentication [auth-scopes]: https://developers.google.com/identity/protocols/oauth2/scopes [predefined-iam-roles]: https://cloud.google.com/iam/docs/understanding-roles#predefined_roles diff --git a/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java b/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java index 1d8a90df1c..339df1dbaf 100644 --- a/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java +++ b/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java @@ -373,6 +373,11 @@ public static GoogleCredentialsProvider.Builder defaultCredentialsProviderBuilde .setJwtEnabledScopes(JWT_ENABLED_SCOPES); } + @Override + public String getServiceName() { + return "bigtable"; + } + /** * Returns the object with the settings used for calls to ReadRows. *