Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use BigtableDataClient directly #2067

Closed
14 of 18 tasks
sduskis opened this issue Feb 6, 2019 · 2 comments
Closed
14 of 18 tasks

Don't use BigtableDataClient directly #2067

sduskis opened this issue Feb 6, 2019 · 2 comments
Assignees
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API.

Comments

@sduskis
Copy link
Contributor

sduskis commented Feb 6, 2019

All of these references need to be removed.

  • Dataflow

  • One offs

    • ./bigtable-test/bigtable-emulator-maven-plugin/src/it/simple-it/src/test/java/SimpleIT.java. This was fixed in Updating emulator test to use the wrapper #2078.
    • ./bigtable-client-core-parent/bigtable-hbase/src/test/java/com/google/cloud/bigtable/hbase/PutMicroBenchmark.java. This class should be removed.
  • Client Core

    • ./bigtable-client-core-parent/bigtable-client-core/src/test/java/com/google/cloud/bigtable/grpc/async/TestBulkMutation.java
    • ./bigtable-client-core-parent/bigtable-client-core/src/test/java/com/google/cloud/bigtable/grpc/async/TestBulkMutationAwaitCompletion.java
    • ./bigtable-client-core-parent/bigtable-client-core/src/test/java/com/google/cloud/bigtable/grpc/async/TestAsyncExecutor.java. This was removed
    • ./bigtable-client-core-parent/bigtable-client-core/src/test/java/com/google/cloud/bigtable/grpc/async/TestBulkRead.java. Fixed in BulkRead uses the new client wrapper #2064
    • ./bigtable-client-core-parent/bigtable-client-core/src/main/java/com/google/cloud/bigtable/grpc/async/RetryingMutateRowsOperation.java NOTE: This is only a reference via a comment, which is appropriate to keep.
    • `./bigtable-client-core-parent/bigtable-client-core/src/main/java/com/google/cloud/bigtable/grpc/async/BulkRead.java
    • ./bigtable-client-core-parent/bigtable-client-core/src/main/java/com/google/cloud/bigtable/grpc/async/AsyncExecutor.java. This class was removed
    • ./bigtable-client-core-parent/bigtable-client-core/src/main/java/com/google/cloud/bigtable/grpc/async/BulkMutation.java
    • ./bigtable-client-core-parent/bigtable-client-core/src/main/java/com/google/cloud/bigtable/grpc/async/MutateRowsRequestManager.java NOTE: This is only a reference via a comment, which is appropriate to keep, since BigtableDataClient uses this class.
  • HBase 1

    • ./bigtable-client-core-parent/bigtable-hbase/src/test/java/com/google/cloud/bigtable/hbase/TestBigtableTable.java.
    • ./bigtable-client-core-parent/bigtable-hbase/src/main/java/com/google/cloud/bigtable/hbase/BigtableRegionLocator.java.
    • ./bigtable-client-core-parent/bigtable-hbase/src/main/java/com/google/cloud/bigtable/hbase/AbstractBigtableTable.java.
    • ./bigtable-client-core-parent/bigtable-hbase/src/main/java/com/google/cloud/bigtable/hbase/AbstractBigtableRegionLocator.java.
  • HBase 2

    • ./bigtable-hbase-2.x-parent/bigtable-hbase-2.x/src/main/java/com/google/cloud/bigtable/hbase2_x/BigtableAsyncTableRegionLocator.java.
    • ./bigtable-hbase-2.x-parent/bigtable-hbase-2.x/src/main/java/com/google/cloud/bigtable/hbase2_x/BigtableDataClient.java
@sduskis
Copy link
Contributor Author

sduskis commented Feb 7, 2019

There are two major issues left:

  1. Bulk mutations - We need a way to cheaply convert MutateRowsRequet.Entry protos to model.Mutation. That needs a change in google-cloud-java
  2. ReadModifyWrite - We need a way to convert the proto Row response to model.Row. That was implemented here: Bigtable: expose helper to convert proto rows into model rows google-cloud-java#4458. Once there's a new google-cloud-bigtable release, we can convert ReadModifyWrite to the wrapper.

@sduskis
Copy link
Contributor Author

sduskis commented Feb 28, 2019

ReadModifyWrite is done. BulkMutations is fine as is, and we use IBulkMutation for HBase, which meets our core objective.

@sduskis sduskis closed this as completed Feb 28, 2019
@google-cloud-label-sync google-cloud-label-sync bot added the api: bigtable Issues related to the googleapis/java-bigtable-hbase API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API.
Projects
None yet
Development

No branches or pull requests

1 participant