fix: unnecessary boxed primitives in AutoValue classes #3460
Conversation
product-auto-label
bot
added
size: xs
|
/gcbrun |
|
Generally looks good. |
cushon
changed the title
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Fixes
```
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableResult.java:42: error: [AutoValueUnnecessaryBoxing] property method com.google.cloud.bigquery.TableResult.getTotalRows() is primitive but parameter of setter method is not
public abstract TableResult.Builder setTotalRows(Long totalRows);
^
```
See google/auto@328a25c
cushon
force-pushed
the
AutoValueUnnecessaryBoxing
branch
from
47db5ae to
c29f669
Compare
Thanks, done! |
|
@cushon , it seems like ci / clirr is still failing. |
|
@cushon is out for a couple more days, but I've been wondering: Would it make sense to leave the old method in place but as |
Thanks, I'm going to try that out, I pushed another commit. |
product-auto-label
bot
added
size: s
|
I'm still getting a clirr error, any ideas what why the exemption isn't sufficient? |
| <difference> | ||
| <differenceType>7005</differenceType> |
There was a problem hiding this comment.
| <differenceType>7005</differenceType> | |
| <differenceType>7013</differenceType> |
It looks like it's now complaining about a new abstract method, I assume on the theory that subclasses would have to implement it. Given that the only subclass here will be the one generated by AutoValue (I hope :)), we should be able to suppress that, too.
Since the old method continues to exist in this iteration of the PR, that suppression can replace the old one from the time of the method removal. With that change, JOB_TYPE=clirr .kokoro/build.sh appears to pass.
Fixes
See google/auto@328a25c
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #3459 ☕️
If you write sample code, please follow the samples format.