Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/quicktype-wrapper Support multi-file output/quicktype MultiFileRenderResult #83

Closed
grant opened this issue Oct 3, 2020 · 0 comments · Fixed by #84
Closed

tools/quicktype-wrapper Support multi-file output/quicktype MultiFileRenderResult #83

grant opened this issue Oct 3, 2020 · 0 comments · Fixed by #84
Assignees
@grant
Labels
api: eventarc Issues related to the googleapis/google-cloudevents API.

Comments

@grant
Copy link
Contributor

grant commented Oct 3, 2020

Expected Behavior

The qt tool should be able to write to multiple files if that's what quicktype tool produces. For example, Java expects this.

Actual Behavior

The tool assumes the output is to one file.

Fix

Use a MultiFileRenderResult rather than a SerializedRenderResult.

https://github.com/quicktype/quicktype/blob/master/src/quicktype-core/TargetLanguage.ts

Steps to Reproduce the Problem

Try producing Java code. It'll output a single file but with comments of the expected file names and file contents.
@grant grant self-assigned this Oct 3, 2020
@product-auto-label product-auto-label bot added the api: eventarc Issues related to the googleapis/google-cloudevents API. label Oct 3, 2020
This was referenced Oct 3, 2020
Merged
Merged
@grant grant closed this as completed in #84 Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grant grant

Labels
api: eventarc Issues related to the googleapis/google-cloudevents API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support multi-file exports for qt googleapis/google-cloudevents
1 participant
@grant