Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add descriptions to JSON Schema fields for IDE autocompletion #66

Closed
grant opened this issue Sep 10, 2020 · 0 comments · Fixed by #75
Closed

Add descriptions to JSON Schema fields for IDE autocompletion #66

grant opened this issue Sep 10, 2020 · 0 comments · Fixed by #75
Assignees
@grant
Labels
api: eventarc Issues related to the googleapis/google-cloudevents API.

Comments

@grant
Copy link
Contributor

grant commented Sep 10, 2020

Expected Behavior

The JSON Schemas should have detailed descriptions for each field, so that we get nice descriptions in our autocompletion.

Actual Behavior

The JSON Schemas don't have description fields.

Example:
https://github.com/googleapis/google-cloudevents/blob/master/proto/google/events/cloud/pubsub/v1/schema.json#L12
@product-auto-label product-auto-label bot added the api: events Issues related to the googleapis/google-cloudevents API. label Sep 10, 2020
@product-auto-label product-auto-label bot added api: eventarc Issues related to the googleapis/google-cloudevents API. and removed api: events Issues related to the googleapis/google-cloudevents API. labels Sep 22, 2020
@grant grant mentioned this issue Sep 29, 2020
Merged
@grant grant closed this as completed in #75 Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grant grant

Labels
api: eventarc Issues related to the googleapis/google-cloudevents API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update JSON Schema descriptions and references googleapis/google-cloudevents
1 participant
@grant