feat: Update JSON Schemas to Use Definitions for all Properties #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: eventarc
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
anniefu
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates JSON schema proto plugin
PROTOC_PLUGIN_VERSION=1.3.1@chrusty made a great change to the JSON schema generator to put all definitions very clearly uniform (and re-usable in the future). They are much more readable now.
This change updates the JSON schemas with a bump to the plug-in. I suspect there will not be significant JSON schema changes after this one.
I spend a good amount of time fixing the postgen step. It's a bit simpler now. I don't expect you to understand details about this PR, but I'd like to get it merged.
This issue should be easier to address after this change too: #180