Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Protoc Plugin Pinned Version #195

Closed
grant opened this issue Mar 26, 2021 · 0 comments · Fixed by #196
Closed

Fix Protoc Plugin Pinned Version #195

grant opened this issue Mar 26, 2021 · 0 comments · Fixed by #196
Assignees
@grant
Labels
api: eventarc Issues related to the googleapis/google-cloudevents API. triage me I really want to be triaged.

Comments

@grant
Copy link
Contributor

grant commented Mar 26, 2021

Expected Behavior

The chrusty tool that generates JSON schemas should be pinned to ensure reproducable results.

Actual Behavior

It looks like the chrusty tool is using master from the repo.

Steps to Reproduce the Problem

Run ./scripts/gen.sh.
@grant grant self-assigned this Mar 26, 2021
@product-auto-label product-auto-label bot added the api: eventarc Issues related to the googleapis/google-cloudevents API. label Mar 26, 2021
@grant grant mentioned this issue Mar 26, 2021
Merged
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grant grant

Labels
api: eventarc Issues related to the googleapis/google-cloudevents API. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correctly pin json schema generator tool googleapis/google-cloudevents
2 participants
@grant @yoshi-automation