From c44f61e3fb032ec4b4e0fa8603e23c08bee59bab Mon Sep 17 00:00:00 2001 From: Daniel Gorelik Date: Tue, 18 Jun 2019 12:56:06 -0400 Subject: [PATCH] Use kwargs in test_subscriber_client This prevents test failures in case the ordering of the keyword arguments to the `StreamingPullManager.open` is switched --- .../unit/pubsub_v1/subscriber/test_subscriber_client.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/pubsub/tests/unit/pubsub_v1/subscriber/test_subscriber_client.py b/pubsub/tests/unit/pubsub_v1/subscriber/test_subscriber_client.py index 8bdb414c6280..b367733aa705 100644 --- a/pubsub/tests/unit/pubsub_v1/subscriber/test_subscriber_client.py +++ b/pubsub/tests/unit/pubsub_v1/subscriber/test_subscriber_client.py @@ -73,7 +73,9 @@ def test_subscribe(manager_open): assert future._manager._subscription == "sub_name_a" manager_open.assert_called_once_with( - mock.ANY, mock.sentinel.callback, future.set_exception + mock.ANY, + callback=mock.sentinel.callback, + on_callback_error=future.set_exception, ) @@ -100,5 +102,7 @@ def test_subscribe_options(manager_open): assert future._manager.flow_control == flow_control assert future._manager._scheduler == scheduler manager_open.assert_called_once_with( - mock.ANY, mock.sentinel.callback, future.set_exception + mock.ANY, + callback=mock.sentinel.callback, + on_callback_error=future.set_exception, )