Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PubSub: Refactor fake leaser helper in streaming pull unit tests #9631

Closed
plamut opened this issue Nov 7, 2019 · 0 comments · Fixed by #9632
Closed

PubSub: Refactor fake leaser helper in streaming pull unit tests #9631

plamut opened this issue Nov 7, 2019 · 0 comments · Fixed by #9632
Assignees
@plamut
Labels
api: pubsub Issues related to the Pub/Sub API. type: cleanup An internal cleanup or hygiene concern.

Comments

@plamut
Copy link
Contributor

plamut commented Nov 7, 2019

Following the comment, the fake leaser's add() method should not hardcode the message size. Instead, the message size should be configurable.
@plamut plamut added api: pubsub Issues related to the Pub/Sub API. type: cleanup An internal cleanup or hygiene concern. labels Nov 7, 2019
@plamut plamut self-assigned this Nov 7, 2019
@plamut plamut mentioned this issue Nov 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamut plamut

Labels
api: pubsub Issues related to the Pub/Sub API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(pubsub): refactor fake leaser test helper plamut/google-cloud-python
1 participant
@plamut