Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting Gapic/Proto (autogen files) #1492

Closed
callmehiphop opened this issue Aug 15, 2016 · 8 comments · Fixed by #2351
Closed

Documenting Gapic/Proto (autogen files) #1492

callmehiphop opened this issue Aug 15, 2016 · 8 comments · Fixed by #2351
Assignees
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.

Comments

@callmehiphop
Copy link
Contributor

Opening an issue to track discussion on how we should go about documenting GAX from within our library.

@callmehiphop
Copy link
Contributor Author

My initial thoughts are that users who take advantage of GAX will be a bit more advanced. That being said, it might not be unreasonable to simply link them to the proto files being used? Then from within our library we can document the methods that expose said APIs v2, v1beta1, etc.

It also might benefit us to look into adding the feature discussed here - https://github.com/GoogleCloudPlatform/gcloud-common/issues/80

@stephenplusplus
Copy link
Contributor

cc: @jmuk @jmdobry

Is it a requirement for us to display autogen docs, or is linking to proto files sufficient?

@jmdobry
Copy link
Contributor

jmdobry commented Aug 16, 2016

For now at least, I think linking to proto files is sufficient.

@jmuk
Copy link
Contributor

jmuk commented Aug 16, 2016

Cc: @omaray

We want the documentation for GAX (i.e. LanguageServiceApi). The generated files are more language-idiomatic and serve methods with additional features such as parameter-flattening / page-streaming, that are not seen in the proto files. We will also add auto-generated usage samples to individual method.

@omaray
Copy link

omaray commented Aug 17, 2016

Correct. We want the documentation of GAPIC/GAX to show. Not every API will have a handwritten layer (or at least at the beginning). So we want to show the docs of the auto-gen too.

@stephenplusplus
Copy link
Contributor

Just tagging as these are related: https://github.com/GoogleCloudPlatform/gcloud-common/issues/207

@jmuk jmuk changed the title Documenting GAX Documenting Gapic (autogen files) Mar 7, 2017
@jmuk jmuk added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. Status: Acknowledged labels Mar 7, 2017
@swcloud swcloud changed the title Documenting Gapic (autogen files) Documenting Gapic/Proto (autogen files) Jun 9, 2017
@stephenplusplus
Copy link
Contributor

@swcloud @callmehiphop

We're live with:

@swcloud
Copy link
Contributor

swcloud commented Jun 30, 2017

@stephenplusplus Looks amazing! We finally did it!! Really appreciate your great work!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants