From 920bf49bd3b50ff2820c6d01e6750e030f9c7f94 Mon Sep 17 00:00:00 2001 From: Yoshi Automation Bot Date: Fri, 13 Sep 2019 10:30:16 -0700 Subject: [PATCH] docs: updates comments in protos --- .../google/cloud/vision/v1/product_search.proto | 12 ++++++------ .../cloud/vision/v1/product_search_service.proto | 6 +++--- .../cloud/vision/v1p4beta1/product_search.proto | 12 ++++++------ .../vision/v1p4beta1/product_search_service.proto | 9 +++------ .../doc/google/cloud/vision/v1/doc_product_search.js | 12 ++++++------ .../cloud/vision/v1/doc_product_search_service.js | 6 +++--- .../cloud/vision/v1p4beta1/doc_product_search.js | 12 ++++++------ .../vision/v1p4beta1/doc_product_search_service.js | 9 +++------ packages/google-cloud-vision/synth.metadata | 6 +++--- 9 files changed, 39 insertions(+), 45 deletions(-) diff --git a/packages/google-cloud-vision/protos/google/cloud/vision/v1/product_search.proto b/packages/google-cloud-vision/protos/google/cloud/vision/v1/product_search.proto index 065e3d54c2c..28d36abbb9a 100644 --- a/packages/google-cloud-vision/protos/google/cloud/vision/v1/product_search.proto +++ b/packages/google-cloud-vision/protos/google/cloud/vision/v1/product_search.proto @@ -43,12 +43,12 @@ message ProductSearchParams { string product_set = 6; // The list of product categories to search in. Currently, we only consider - // the first category, and either "homegoods-v2", "apparel-v2", or "toys-v2" - // should be specified. The legacy categories "homegoods", "apparel", and - // "toys" are still supported but will be deprecated. For new products, please - // use "homegoods-v2", "apparel-v2", or "toys-v2" for better product search - // accuracy. It is recommended to migrate existing products to these - // categories as well. + // the first category, and either "homegoods-v2", "apparel-v2", "toys-v2", + // "packagedgoods-v1", or "general-v1" should be specified. The legacy + // categories "homegoods", "apparel", and "toys" are still supported but will + // be deprecated. For new products, please use "homegoods-v2", "apparel-v2", + // or "toys-v2" for better product search accuracy. It is recommended to + // migrate existing products to these categories as well. repeated string product_categories = 7; // The filtering expression. This can be used to restrict search results based diff --git a/packages/google-cloud-vision/protos/google/cloud/vision/v1/product_search_service.proto b/packages/google-cloud-vision/protos/google/cloud/vision/v1/product_search_service.proto index 0fae1f80a65..a892a6fb6bb 100644 --- a/packages/google-cloud-vision/protos/google/cloud/vision/v1/product_search_service.proto +++ b/packages/google-cloud-vision/protos/google/cloud/vision/v1/product_search_service.proto @@ -375,9 +375,9 @@ message Product { string description = 3; // The category for the product identified by the reference image. This should - // be either "homegoods-v2", "apparel-v2", or "toys-v2". The legacy categories - // "homegoods", "apparel", and "toys" are still supported, but these should - // not be used for new products. + // be either "homegoods-v2", "apparel-v2", "toys-v2", "packagedgoods-v1", or + // "general-v1" The legacy categories "homegoods", "apparel", and "toys" are + // still supported, but these should not be used for new products. // // This field is immutable. string product_category = 4; diff --git a/packages/google-cloud-vision/protos/google/cloud/vision/v1p4beta1/product_search.proto b/packages/google-cloud-vision/protos/google/cloud/vision/v1p4beta1/product_search.proto index 1caf30194f5..e0982facdcc 100644 --- a/packages/google-cloud-vision/protos/google/cloud/vision/v1p4beta1/product_search.proto +++ b/packages/google-cloud-vision/protos/google/cloud/vision/v1p4beta1/product_search.proto @@ -44,12 +44,12 @@ message ProductSearchParams { string product_set = 6; // The list of product categories to search in. Currently, we only consider - // the first category, and either "homegoods-v2", "apparel-v2", "toys-v2", or - // "packagedgoods-v1" should be specified. The legacy categories "homegoods", - // "apparel", and "toys" are still supported but will be deprecated. For new - // products, please use "homegoods-v2", "apparel-v2", or "toys-v2" for better - // product search accuracy. It is recommended to migrate existing products to - // these categories as well. + // the first category, and either "homegoods-v2", "apparel-v2", "toys-v2", + // "packagedgoods-v1", or "general-v1" should be specified. The legacy + // categories "homegoods", "apparel", and "toys" are still supported but will + // be deprecated. For new products, please use "homegoods-v2", "apparel-v2", + // or "toys-v2" for better product search accuracy. It is recommended to + // migrate existing products to these categories as well. repeated string product_categories = 7; // The filtering expression. This can be used to restrict search results based diff --git a/packages/google-cloud-vision/protos/google/cloud/vision/v1p4beta1/product_search_service.proto b/packages/google-cloud-vision/protos/google/cloud/vision/v1p4beta1/product_search_service.proto index 3cbc53573f1..28d7378b249 100644 --- a/packages/google-cloud-vision/protos/google/cloud/vision/v1p4beta1/product_search_service.proto +++ b/packages/google-cloud-vision/protos/google/cloud/vision/v1p4beta1/product_search_service.proto @@ -355,12 +355,9 @@ message Product { string description = 3; // The category for the product identified by the reference image. This should - // be either "homegoods-v2", "apparel-v2", "toys-v2", or "packagedgoods-v1". - // The legacy categories "homegoods", "apparel", and "toys" are still - // supported but will be deprecated. For new products, please use - // "homegoods-v2", "apparel-v2", or "toys-v2" for better product search - // accuracy. It is recommended to migrate existing products to these - // categories as well. + // be either "homegoods-v2", "apparel-v2", "toys-v2", "packagedgoods-v1", or + // "general-v1" The legacy categories "homegoods", "apparel", and "toys" are + // still supported, but these should not be used for new products. // // This field is immutable. string product_category = 4; diff --git a/packages/google-cloud-vision/src/v1/doc/google/cloud/vision/v1/doc_product_search.js b/packages/google-cloud-vision/src/v1/doc/google/cloud/vision/v1/doc_product_search.js index d2c58ea4bf0..a20c5d3902e 100644 --- a/packages/google-cloud-vision/src/v1/doc/google/cloud/vision/v1/doc_product_search.js +++ b/packages/google-cloud-vision/src/v1/doc/google/cloud/vision/v1/doc_product_search.js @@ -33,12 +33,12 @@ * * @property {string[]} productCategories * The list of product categories to search in. Currently, we only consider - * the first category, and either "homegoods-v2", "apparel-v2", or "toys-v2" - * should be specified. The legacy categories "homegoods", "apparel", and - * "toys" are still supported but will be deprecated. For new products, please - * use "homegoods-v2", "apparel-v2", or "toys-v2" for better product search - * accuracy. It is recommended to migrate existing products to these - * categories as well. + * the first category, and either "homegoods-v2", "apparel-v2", "toys-v2", + * "packagedgoods-v1", or "general-v1" should be specified. The legacy + * categories "homegoods", "apparel", and "toys" are still supported but will + * be deprecated. For new products, please use "homegoods-v2", "apparel-v2", + * or "toys-v2" for better product search accuracy. It is recommended to + * migrate existing products to these categories as well. * * @property {string} filter * The filtering expression. This can be used to restrict search results based diff --git a/packages/google-cloud-vision/src/v1/doc/google/cloud/vision/v1/doc_product_search_service.js b/packages/google-cloud-vision/src/v1/doc/google/cloud/vision/v1/doc_product_search_service.js index 9219fa93848..dd4c9fef11f 100644 --- a/packages/google-cloud-vision/src/v1/doc/google/cloud/vision/v1/doc_product_search_service.js +++ b/packages/google-cloud-vision/src/v1/doc/google/cloud/vision/v1/doc_product_search_service.js @@ -36,9 +36,9 @@ * * @property {string} productCategory * The category for the product identified by the reference image. This should - * be either "homegoods-v2", "apparel-v2", or "toys-v2". The legacy categories - * "homegoods", "apparel", and "toys" are still supported, but these should - * not be used for new products. + * be either "homegoods-v2", "apparel-v2", "toys-v2", "packagedgoods-v1", or + * "general-v1" The legacy categories "homegoods", "apparel", and "toys" are + * still supported, but these should not be used for new products. * * This field is immutable. * diff --git a/packages/google-cloud-vision/src/v1p4beta1/doc/google/cloud/vision/v1p4beta1/doc_product_search.js b/packages/google-cloud-vision/src/v1p4beta1/doc/google/cloud/vision/v1p4beta1/doc_product_search.js index 4c64089b693..c3000e086b3 100644 --- a/packages/google-cloud-vision/src/v1p4beta1/doc/google/cloud/vision/v1p4beta1/doc_product_search.js +++ b/packages/google-cloud-vision/src/v1p4beta1/doc/google/cloud/vision/v1p4beta1/doc_product_search.js @@ -34,12 +34,12 @@ * * @property {string[]} productCategories * The list of product categories to search in. Currently, we only consider - * the first category, and either "homegoods-v2", "apparel-v2", "toys-v2", or - * "packagedgoods-v1" should be specified. The legacy categories "homegoods", - * "apparel", and "toys" are still supported but will be deprecated. For new - * products, please use "homegoods-v2", "apparel-v2", or "toys-v2" for better - * product search accuracy. It is recommended to migrate existing products to - * these categories as well. + * the first category, and either "homegoods-v2", "apparel-v2", "toys-v2", + * "packagedgoods-v1", or "general-v1" should be specified. The legacy + * categories "homegoods", "apparel", and "toys" are still supported but will + * be deprecated. For new products, please use "homegoods-v2", "apparel-v2", + * or "toys-v2" for better product search accuracy. It is recommended to + * migrate existing products to these categories as well. * * @property {string} filter * The filtering expression. This can be used to restrict search results based diff --git a/packages/google-cloud-vision/src/v1p4beta1/doc/google/cloud/vision/v1p4beta1/doc_product_search_service.js b/packages/google-cloud-vision/src/v1p4beta1/doc/google/cloud/vision/v1p4beta1/doc_product_search_service.js index 636dc9077ee..77b496dba6b 100644 --- a/packages/google-cloud-vision/src/v1p4beta1/doc/google/cloud/vision/v1p4beta1/doc_product_search_service.js +++ b/packages/google-cloud-vision/src/v1p4beta1/doc/google/cloud/vision/v1p4beta1/doc_product_search_service.js @@ -36,12 +36,9 @@ * * @property {string} productCategory * The category for the product identified by the reference image. This should - * be either "homegoods-v2", "apparel-v2", "toys-v2", or "packagedgoods-v1". - * The legacy categories "homegoods", "apparel", and "toys" are still - * supported but will be deprecated. For new products, please use - * "homegoods-v2", "apparel-v2", or "toys-v2" for better product search - * accuracy. It is recommended to migrate existing products to these - * categories as well. + * be either "homegoods-v2", "apparel-v2", "toys-v2", "packagedgoods-v1", or + * "general-v1" The legacy categories "homegoods", "apparel", and "toys" are + * still supported, but these should not be used for new products. * * This field is immutable. * diff --git a/packages/google-cloud-vision/synth.metadata b/packages/google-cloud-vision/synth.metadata index a034b06d0a7..2b20c7b87c1 100644 --- a/packages/google-cloud-vision/synth.metadata +++ b/packages/google-cloud-vision/synth.metadata @@ -1,5 +1,5 @@ { - "updateTime": "2019-09-06T11:26:58.194033Z", + "updateTime": "2019-09-13T11:29:41.331321Z", "sources": [ { "generator": { @@ -12,8 +12,8 @@ "git": { "name": "googleapis", "remote": "https://github.com/googleapis/googleapis.git", - "sha": "960b76b1f0c46d12610088977d1129cc7405f3dc", - "internalRef": "267478864" + "sha": "dc88acb2ced136067d3ed2356b6a87ca7f017a96", + "internalRef": "268735517" } }, {