Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

META-INF/services/ files are incorrect in shaded google-cloud-nio jar #3540

Closed
lbergelson opened this issue Aug 8, 2018 · 2 comments
Closed

META-INF/services/ files are incorrect in shaded google-cloud-nio jar #3540

lbergelson opened this issue Aug 8, 2018 · 2 comments
Assignees
@JesseLovelace
Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@lbergelson
Copy link

The google-cloud-nio-0.56.0-alpha-shaded.jar doesn't correctly update the services files for shaded dependencies.
Specifically the two files
META-INF/services/org.threeten.bp.zone.TzdbZoneRulesProvider
and
META-INF/services/com.fasterxml.jackson.core.JsonFactory should probably be updated to point to the shaded version of those classes instead.
This was referenced Aug 8, 2018
Closed
Closed
@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Aug 9, 2018
@yihanzhen yihanzhen added api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 9, 2018
@JustinBeckwith JustinBeckwith removed the triage me I really want to be triaged. label Aug 9, 2018
@andrey-qlogic
Copy link

Hi @hzyi-google, is the process bug still reproducible?

@yihanzhen
Copy link
Contributor

Yes it is. The two files are still pointing at the non-shaded version of those classes in the latest google-cloud-nio on maven (0.74).

@andrey-qlogic andrey-qlogic mentioned this issue Dec 31, 2018
Closed
@andrey-qlogic andrey-qlogic mentioned this issue Jan 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JesseLovelace JesseLovelace

Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@JustinBeckwith @lbergelson @yihanzhen @JesseLovelace @andrey-qlogic