google.auth.default(quota_project_id="..") still results in end user credentials warning

[busunkim96]

quota_project_id is not currently passed through to _get_gcloud_sdk_credentials. This bit of code still results in the end user credentials warning:

import google.auth

credentials, project_id = google.auth.default(quota_project_id="my-project")

google-auth-library-python/google/auth/_default.py

Lines 177 to 195 in 09e0389

	def _get_gcloud_sdk_credentials():
	"""Gets the credentials and project ID from the Cloud SDK."""
	from google.auth import _cloud_sdk
	_LOGGER.debug("Checking Cloud SDK credentials as part of auth process...")
	# Check if application default credentials exist.
	credentials_filename = _cloud_sdk.get_application_default_credentials_path()
	if not os.path.isfile(credentials_filename):
	_LOGGER.debug("Cloud SDK credentials not found on disk; not using them")
	return None, None
	credentials, project_id = load_credentials_from_file(credentials_filename)
	if not project_id:
	project_id = _cloud_sdk.get_project_id()
	return credentials, project_id

google-auth-library-python/google/auth/_default.py

Lines 73 to 75 in 09e0389

	def load_credentials_from_file(
	filename, scopes=None, default_scopes=None, quota_project_id=None, request=None
	):

[busunkim96]

Hey @arithmetic1728,

Re-visiting this as it recently went OOSLO. Should a quota project passed explicitly to google.auth.default(quota_project_id="my-project") silence the warning? Or should the project be explicitly added through gcloud?

google-auth-library-python/google/auth/_default.py

Lines 50 to 70 in 09e0389

	# Warning when using Cloud SDK user credentials
	_CLOUD_SDK_CREDENTIALS_WARNING = """\
	Your application has authenticated using end user credentials from Google \
	Cloud SDK without a quota project. You might receive a "quota exceeded" \
	or "API not enabled" error. We recommend you rerun \
	`gcloud auth application-default login` and make sure a quota project is \
	added. Or you can use service accounts instead. For more information \
	about service accounts, see https://cloud.google.com/docs/authentication/"""
	def _warn_about_problematic_credentials(credentials):
	"""Determines if the credentials are problematic.
	Credentials from the Cloud SDK that are associated with Cloud SDK's project
	are problematic because they may not have APIs enabled and have limited
	quota. If this is the case, warn about it.
	"""
	from google.auth import _cloud_sdk
	if credentials.client_id == _cloud_sdk.CLOUD_SDK_CLIENT_ID:
	warnings.warn(_CLOUD_SDK_CREDENTIALS_WARNING)

[arithmetic1728]

@busunkim96 yes, we should silence the error if the quota project id is provided via google.auth.default(quota_project_id="my-project"). I will write a PR to address it.