Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add integration tests for pluggable auth #1073

Merged
merged 8 commits into from
Aug 1, 2022
Merged

feat: add integration tests for pluggable auth #1073

merged 8 commits into from
Aug 1, 2022

Conversation

ScruffyProdigy
Copy link
Contributor

No description provided.

TimurSadykov
TimurSadykov suggested changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far only comment request, in progress

system_tests/system_tests_sync/test_external_accounts.py Show resolved Hide resolved
TimurSadykov
TimurSadykov approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add comments to the test )

@ScruffyProdigy ScruffyProdigy requested a review from a team as a code owner July 26, 2022 19:47
clundin25
clundin25 reviewed Jul 28, 2022
View reviewed changes
system_tests/noxfile.py Outdated
def external_accounts(session):
session.env[ALLOW_PLUGGABLE_ENV] = "1"
session.install(
*TEST_DEPENDENCIES_SYNC,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to change as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, without this environment variable set, pluggable auth tests will fail

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant the test dependencies, only *TEST_DEPENDENCIES_SYNC was being used and I assumed they would need to be updated to *TEST_DEPENDENCIES_ASYNC to reflect the nox session change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, gotcha. I updated the nox session to use SYNC instead, because I believe Chuan updated the code to work with 2.7

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it failed with 2.7 :(

I don't have the context for this so I'm okay with moving it back to how you had it

@clundin25
Copy link
Contributor

clundin25 commented Jul 28, 2022 •
edited
Loading

You'll need a fresh token for the Kokoro system tests. I pushed one here that you can pull in

@clundin25 clundin25 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 28, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 28, 2022
@clundin25 clundin25 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 28, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 28, 2022
@clundin25 clundin25 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 28, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 28, 2022
@clundin25 clundin25 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 1, 2022
@clundin25 clundin25 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 1, 2022
@clundin25 clundin25 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 1, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 1, 2022
@clundin25 clundin25 merged commit f8d776a into googleapis:main Aug 1, 2022
@release-please release-please bot mentioned this pull request Aug 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clundin25 clundin25 clundin25 left review comments

@sai-sunder-s sai-sunder-s sai-sunder-s approved these changes

@TimurSadykov TimurSadykov TimurSadykov approved these changes

@arithmetic1728 arithmetic1728 Awaiting requested review from arithmetic1728

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ScruffyProdigy @clundin25 @TimurSadykov @sai-sunder-s @yoshi-kokoro