-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update developer.google.com docs #285
Comments
cc @jonparrott |
If you can send me what the new Node.js sample for https://developers.google.com/identity/sign-in/web/backend-auth#using-a-google-api-client-library should be, I'll update it in the docs. |
From a process perspective - is there a way to get these samples into source control and tested, similar to what you do with cloudsite? This is going to be a persistent problem otherwise. |
Quick ping :) @jonparrott @jmdobry |
Maybe, as a first step, add a warning message about the outdated documentation |
I submitted a PR that I'm waiting for approval on. I'm closing this one as a dup of #251 since it's about the same doc :) |
With the breaking changes in the 1.0 release, it looks like we left some outdated code samples lying around:
#243 (comment)
For example, this has the signature of
verifyIdToken
wrong:https://developers.google.com/identity/sign-in/web/backend-auth#send-the-id-token-to-your-server
I'm happy to do GitHub stuff, but once it gets into Google3 I'd very much prefer someone else take this on :)
The text was updated successfully, but these errors were encountered: