Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to ensure typescript users can use this module #178

Closed
ofrobots opened this issue Nov 8, 2017 · 1 comment
Closed

Add test to ensure typescript users can use this module #178

ofrobots opened this issue Nov 8, 2017 · 1 comment
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Milestone

Comments

@ofrobots
Copy link
Contributor

ofrobots commented Nov 8, 2017

Originally reported by @dauledk on #177 (comment).

However I still get a ton of compile errors when building. A lot of them comes from the google-auth-library. Like this one

<full-path-to-project>/node_modules/google-auth-library/types/lib/transporters.d.ts(1,23): error TS2688: Cannot find type definition file for 'request'.`
@ofrobots
Copy link
Contributor Author

ofrobots commented Nov 9, 2017

@dauledk tracked down the reason to an bug in types in one of our dependencies: #179. That issue can be used to investigate switching dependencies.

Let's use this bug for adding a test to make sure our type definitions are actually usable by users.

@ofrobots ofrobots changed the title Typescript users get compiler errors about missing types for request Add test to ensure typescript users can use this module Nov 9, 2017
@JustinBeckwith JustinBeckwith self-assigned this Nov 25, 2017
@ofrobots ofrobots added this to the 1.0 milestone Nov 28, 2017
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants