Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'GoogleAuth<JSONClient> | undefined' is not assignable to type 'JSONClient | undefined'. #1374

Closed
zubairzahoor opened this issue Feb 23, 2022 · 2 comments
Closed

'GoogleAuth<JSONClient> | undefined' is not assignable to type 'JSONClient | undefined'. #1374

zubairzahoor opened this issue Feb 23, 2022 · 2 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@zubairzahoor
Copy link

Did the recent update break something?

Types of property 'authClient' are incompatible.
11:08:51 Type 'GoogleAuth | undefined' is not assignable to type 'JSONClient | undefined'.
11:08:51 node_modules/@google-cloud/common/build/src/util.d.ts(42,18): error TS2430: Interface 'MakeAuthenticatedRequestFactoryConfig' incorrectly extends interface 'GoogleAuthOptions'.
11:08:51 Types of property 'authClient' are incompatible.
11:08:51 Type 'GoogleAuth | undefined' is not assignable to type 'JSONClient | undefined'.
11:08:51 Type 'GoogleAuth' is not assignable to type 'JSONClient | undefined'.
11:08:51 Type 'GoogleAuth' is missing the following properties from type 'JWT': createScoped, getRequestMetadataAsync, fetchIdToken, hasUserScopes

Environment details
OS: CentOS
Node.js version: NodeJS_v12.18.2
@google-cloud/common version: 3.9.0

Steps to reproduce
A simple npm run build causes this.
@zubairzahoor zubairzahoor added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 23, 2022
@zubairzahoor zubairzahoor mentioned this issue Feb 23, 2022
Closed
@iPablo
Copy link

iPablo commented Feb 23, 2022

I have the same issue since this morning

@bcoe
Copy link
Contributor

bcoe commented Feb 23, 2022

closing as duplicate of googleapis/nodejs-common#734

google-gax has been rolled back, which was forcing the latest version of auth.

@bcoe bcoe closed this as completed Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bcoe @iPablo @zubairzahoor