Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should use servicePath instead of basePath #114

Closed
tjwebb opened this issue Dec 9, 2013 · 1 comment
Closed

Should use servicePath instead of basePath #114

tjwebb opened this issue Dec 9, 2013 · 1 comment
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@tjwebb
Copy link

tjwebb commented Dec 9, 2013

using basePath returns urls prefixed with an extra slash. should use servicePath here: https://github.com/google/google-api-nodejs-client/blob/ce337ceba02a53dfde7e586c6ef1f58f47699553/lib/requests.js#L143

basePath appears deprecated according to: https://developers.google.com/discovery/v1/using#discovery-doc-apiproperties

@rakyll
Copy link
Contributor

rakyll commented Dec 10, 2013

#109 and #116 fixed double slash problems.

@rakyll rakyll closed this as completed Dec 10, 2013
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
This was referenced Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants