Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-Agent combining inverts the ordering convention #320

Closed
Capstan opened this issue Dec 12, 2018 · 3 comments
Closed

User-Agent combining inverts the ordering convention #320

Capstan opened this issue Dec 12, 2018 · 3 comments
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@Capstan
Copy link

Capstan commented Dec 12, 2018

If you set Service.UserAgent, then that gets appended to the user agent string (e.g., "google-api-go-client/0.5"). RFC 7231 §5.5.3 states,

By convention, the product identifiers are listed in decreasing order of their significance for identifying the user agent software.

Users of the client library are the most important product (i.e., the application or server software itself), followed by any wrapper libraries that might consume and repackage the go client, then the go client.

Suggest you reverse the order and append the client's agent string to any provided user agent.

@jeanbza
Copy link
Contributor

jeanbza commented Dec 12, 2018

Hi @Capstan! Is this in regards to a problem you're experiencing, or more of a semantic concern?

@jeanbza jeanbza added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Dec 12, 2018
@Capstan
Copy link
Author

Capstan commented Dec 12, 2018

It's just a semantic concern.

@codyoss
Copy link
Member

codyoss commented May 21, 2020

Closing this in favor of issue linked above. Thank you for bring this to our attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants