Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gensupport): cover ChunkRetryDeadline edge case #1430

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Feb 9, 2022

Fix an edge case that I noticed when testing a very small
ChunkRetryDeadline via the storage client. If the user
chooses a deadline too short to send a single request for the
chunk, we cause a failure so that resp and err are not
both nil.

Fix an edge case that I noticed when testing a very small
ChunkRetryDeadline via the storage client. If the user
chooses a deadline too short to send a single request for the
chunk, we cause a failure so that resp and err are not
both nil.
@tritone tritone requested review from yoshi-approver and a team as code owners February 9, 2022 04:50
@codyoss codyoss merged commit ef89845 into googleapis:main Feb 9, 2022
@tritone tritone deleted the chunk-deadline-fix branch February 10, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants