feat: Metadata Server Detection Configuration #562
Conversation
Avoids a type issue with gax that requires a major version bump.
|
Warning: This pull request is touching the following templated files:
|
| @@ -2,6 +2,7 @@ | |||
| "extends": "./node_modules/gts/tsconfig-google.json", | |||
| "compilerOptions": { | |||
| "lib": ["es2018", "dom"], | |||
| "skipLibCheck": true, | |||
There was a problem hiding this comment.
Will create a follow-up issue to revert this in the next major (should be soon).
There was a problem hiding this comment.
Background: https://www.typescriptlang.org/tsconfig#skipLibCheck
There's a broken type issue that would require a major version bump to resolve.
There was a problem hiding this comment.
I too got bitten by this broken type issue
There was a problem hiding this comment.
Tracking issue: #564
| @@ -41,6 +41,7 @@ | |||
| "json-bigint": "^1.0.0" | |||
| }, | |||
| "devDependencies": { | |||
| "@babel/plugin-proposal-private-methods": "^7.18.6", | |||
There was a problem hiding this comment.
I see this was added but is it used someplace or did I misunderstand?
There was a problem hiding this comment.
Yea, for some reason compdoc wants the babel plugin now, otherwise it’ll throw and fail the docs check (and linkinator would also complain).
There was a problem hiding this comment.
Update: It's a Node 14+ requirement
There was a problem hiding this comment.
Tracking issue: #563
|
cc: @TimurSadykov |
| return false; | ||
| case 'bios-only': | ||
| return getGCPResidency(); | ||
| case 'ping-only': |
There was a problem hiding this comment.
Maybe we discussed but I forgot.. we don't want to have a default where both ping and bios happen sequentially?
There was a problem hiding this comment.
or default in this case is null and also ping?
There was a problem hiding this comment.
Yea, the default in this case is null and ping - I’m open to changing it.
| } | ||
|
|
||
| return gcpResidencyCache ? 0 : 3000; | ||
| return getGCPResidency() ? 0 : 3000; |
There was a problem hiding this comment.
Curious what timeout it is and why exactly 0?
There was a problem hiding this comment.
The timeout is used for availability checking; 0 (indefinite) for GCE and up to 3 secs for other platforms.
Configure desired metadata server availability check behavior.
(Indirectly) Fixes #548 🦕