Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow IPv6 service addresses #249

Closed
wants to merge 2 commits into from
Closed

Allow IPv6 service addresses #249

wants to merge 2 commits into from

Conversation

jdpedrie
Copy link
Contributor

Fixes #227.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2019
@codecov
Copy link

codecov bot commented Jun 26, 2019 •
edited
Loading

Codecov Report

Merging #249 (373b3e5) into master (0f374a4) will decrease coverage by 0.90%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   92.30%   91.40%   -0.91%     
==========================================
  Files          50       49       -1     
  Lines        2249     2117     -132     
==========================================
- Hits         2076     1935     -141     
- Misses        173      182       +9
Impacted Files Coverage Δ
src/ServiceAddressTrait.php 90.90% <83.33%> (-9.10%) ⬇️
src/Transport/HttpUnaryTransportTrait.php 34.78% <0.00%> (-29.93%) ⬇️
src/ResourceTemplate/Segment.php 83.33% <0.00%> (-4.91%) ⬇️
src/CredentialsWrapper.php 90.90% <0.00%> (-2.28%) ⬇️
src/GapicClientTrait.php 88.34% <0.00%> (-2.12%) ⬇️
src/ResourceTemplate/Parser.php 97.14% <0.00%> (-0.48%) ⬇️
src/Transport/GrpcTransport.php 82.17% <0.00%> (-0.44%) ⬇️
src/Transport/RestTransport.php 92.30% <0.00%> (-0.15%) ⬇️
src/RequestParamsHeaderDescriptor.php 100.00% <0.00%> (ø)
src/ResourceTemplate/RelativeResourceTemplate.php 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d7a941...240fe14. Read the comment docs.

@dwsupplee dwsupplee self-requested a review June 27, 2019 20:36
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jul 3, 2019
@bshaffer bshaffer requested a review from a team as a code owner December 14, 2020 19:21
@jdpedrie jdpedrie closed this Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsupplee dwsupplee Awaiting requested review from dwsupplee

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for IPv6 Addresses in ServiceAddressTrait
4 participants
@jdpedrie @googlebot @yoshi-automation @bshaffer