Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 0.12 from Travis #109

Closed
jmuk opened this issue Feb 17, 2017 · 0 comments
Closed

Remove 0.12 from Travis #109

jmuk opened this issue Feb 17, 2017 · 0 comments
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@jmuk
Copy link
Contributor

jmuk commented Feb 17, 2017

As googleapis/google-cloud-node#1855 (comment)

Node 0.12 has ended its official support at the end of 2016, and gRPC has stopped its distributions of precompiled binary packages for 0.12. This caused the failures on Travis -- because node tries to compile gRPC and its old C++ compiler fails to deal with some language features there.

Instead of adding new C++ compiler, we should be aligned with google-cloud-node repository, that means:

  • specify the minimum version in the package.json to be 4
  • remove 0.12 from Travis
  • however, this does not mean to drop the support of 0.12. For example, we can't use new ES6 features which were added to Node v4.
@jmuk jmuk closed this as completed Feb 21, 2017
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants