Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

SampleGen: Change accessing a map field by key from using { } to using [ ] #2600

Closed
4 tasks
yihanzhen opened this issue Feb 28, 2019 · 6 comments
Closed
4 tasks

SampleGen: Change accessing a map field by key from using { } to using [ ] #2600

yihanzhen opened this issue Feb 28, 2019 · 6 comments
Assignees
@vchudnov-g @yihanzhen
Labels
Core: Sample-gen type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@yihanzhen
Copy link
Contributor

yihanzhen commented Feb 28, 2019 •
edited
Loading

on success:

  • define
  • print

parameters:

  • default
  • attributes
@yihanzhen yihanzhen added Core: Sample-gen priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 28, 2019
@yihanzhen yihanzhen mentioned this issue Feb 28, 2019
Merged
@vchudnov-g vchudnov-g added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 28, 2019
@vchudnov-g
Copy link
Contributor

Marking P1 because it's important we settle this one way or the other before wide adoption, but it's not blocking development of other features.

@landrito
Copy link
Contributor

landrito commented Apr 1, 2019

@hzyi-google any updates on this?

@vchudnov-g
Copy link
Contributor

Let's fix this soon so that micro-generators can directly implement the [ ] style

@yihanzhen
Copy link
Contributor Author

I'll get to this once I finish default calling forms and sample tester manifests.

@vchudnov-g
Copy link
Contributor

We decided to defer this even longer, given the complication of implementing this in the monolith and the relatively higher importance of other features.

@vchudnov-g vchudnov-g added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels May 21, 2019
@sduskis sduskis removed the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jul 3, 2019
@yihanzhen
Copy link
Contributor Author

Moved to backlog. https://github.com/googleapis/gapic-generator/wiki/feature-backlog

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vchudnov-g vchudnov-g

@yihanzhen yihanzhen

Labels
Core: Sample-gen type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sduskis @vchudnov-g @landrito @yihanzhen