-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node.js: Client constructors needs samples. #402
Comments
@lukesneeringer Can you add a priority to this? |
@alexander-fenster Can you add a priority to this? |
In-code samples are not generated by the standalone sample infrastructure yet, so the language owners are still responsible for those. Assigning to @alexander-fenster |
@alexander-fenster any updates? |
@alexander-fenster Can you provide an update? FWIW: The intent is for samplegen to be able to provide in-code samples. Feel free to talk to me and we can discuss in more detail. In short: samplegen is focusing on standalone samples, but once we have those generating the in-code samples should be very simple additional work. |
@alexander-fenster We're out of SLO for this issue. Could you provide an update/resolve, and/or lower the priority? Thanks! |
Since we had no customers' requests on this, I'll change it to P2, and will talk to you about this later when we move to micro-gen on TypeScript. |
In-code samples are going to be taken care of by sample generator. |
Right now, some client constructors (such as DLP; see googleapis/google-cloud-node#2400) do not show any kind of sample or how to construct the object and use it to do anything.
The text was updated successfully, but these errors were encountered: