Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js: Client constructors needs samples. #402

Closed
lukesneeringer opened this issue Jul 18, 2017 · 10 comments
Closed

Node.js: Client constructors needs samples. #402

lukesneeringer opened this issue Jul 18, 2017 · 10 comments
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@lukesneeringer
Copy link
Contributor

Right now, some client constructors (such as DLP; see googleapis/google-cloud-node#2400) do not show any kind of sample or how to construct the object and use it to do anything.

@evaogbe
Copy link

evaogbe commented Aug 16, 2017

@lukesneeringer Can you add a priority to this?

@evaogbe
Copy link

evaogbe commented Nov 29, 2017

@alexander-fenster Can you add a priority to this?

@vchudnov-g
Copy link

In-code samples are not generated by the standalone sample infrastructure yet, so the language owners are still responsible for those. Assigning to @alexander-fenster

@jbolinger
Copy link

@alexander-fenster any updates?

2 similar comments
@landrito
Copy link

landrito commented Jan 2, 2019

@alexander-fenster any updates?

@jbolinger
Copy link

@alexander-fenster any updates?

@vchudnov-g
Copy link

@alexander-fenster Can you provide an update?

FWIW: The intent is for samplegen to be able to provide in-code samples. Feel free to talk to me and we can discuss in more detail. In short: samplegen is focusing on standalone samples, but once we have those generating the in-code samples should be very simple additional work.

@vchudnov-g
Copy link

@alexander-fenster We're out of SLO for this issue. Could you provide an update/resolve, and/or lower the priority? Thanks!

@alexander-fenster
Copy link
Contributor

Since we had no customers' requests on this, I'll change it to P2, and will talk to you about this later when we move to micro-gen on TypeScript.

@yihanzhen yihanzhen transferred this issue from googleapis/gapic-generator Apr 9, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 9, 2020
@alexander-fenster
Copy link
Contributor

In-code samples are going to be taken care of by sample generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

7 participants