-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase code coverage to 100% for generated types #1035
Comments
It looks like there are no types in any of those files... I wonder why they were generated |
@software-dov Please could you take a look to understand the level of difficulty of this one? |
This issue appears to be resolved. |
Out of curiosity, what fixed this? Did the coverage rise to 100% with the most recent release? |
I'm not sure exactly. The files without types disappeared from the coverage list, which is the desired behaviour. In the snippet below Before
After
|
See build log here which shows coverage is missing for
network_security.py
at lines 18-23 here.google/cloud/network_security_v1beta1/types/network_security.py 2 2 0 0 0% 18-23
The specific lines are
The text was updated successfully, but these errors were encountered: