Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignoreMethods configuration option #919

Closed
b-grablabs opened this issue Nov 15, 2018 · 1 comment
Closed

ignoreMethods configuration option #919

b-grablabs opened this issue Nov 15, 2018 · 1 comment
Assignees
@kjin
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. in progress priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@b-grablabs
Copy link

With CORS enabled our stackdriver trace UI is getting overwhelmed with OPTIONS requests. And I think it might not be reporting important requests since I have a sampling rate < # requests / second.

Having an ignoreMethods configuration option similar to ignoreUrls method would solve this.
@kjin kjin self-assigned this Nov 15, 2018
@kjin kjin added in progress priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 15, 2018
@b-grablabs b-grablabs mentioned this issue Nov 15, 2018
Merged
@kjin kjin mentioned this issue Nov 15, 2018
Closed
@kjin
Copy link
Contributor

kjin commented Dec 3, 2018

Hi @b-flightly -- this is available in 3.4.0. Thanks again for your contribution!

@kjin kjin closed this as completed Dec 3, 2018
@google-cloud-label-sync google-cloud-label-sync bot added the api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kjin kjin

Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. in progress priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kjin @b-grablabs