Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-restify.js not upgraded to 8.x #1275

Closed
ghost opened this issue Jun 4, 2020 · 1 comment
Closed

plugin-restify.js not upgraded to 8.x #1275

ghost opened this issue Jun 4, 2020 · 1 comment
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. status: duplicate Duplicate.

Comments

@ghost
Copy link

ghost commented Jun 4, 2020

Hi,

I have tried to get the trace-agent running using restify but it is not working. My question is could it be related to the plugin-restify.js not being properly updated.

I have the same problem locally as with the App Engine Standard environment.

(I don't know if this issue should be filed here or at another place so forgive me if this is the wrong area.)

Environment details

  • OS: Mac OS X 10.15.5
  • Node.js version: v12.16.1
  • npm version: 6.13.4
  • @google-cloud/trace-agent version: 4.2.5

Steps to reproduce

  1. npm install @google-cloud/trace-agent
  2. Browse to ./node_modules/@google-cloud/trace-agent/build/src/plugins/plugin-restify.js
  3. line 16 still says: const SUPPORTED_VERSIONS = '<=7.x';
@product-auto-label product-auto-label bot added the api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. label Jun 4, 2020
@kintel kintel added the status: duplicate Duplicate. label Jun 4, 2020
@kintel
Copy link
Contributor

kintel commented Jun 4, 2020

This was fixed by #1250 and will be released in version 5.0.0 (#1241) which is expected to land soon.

@kintel kintel closed this as completed Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. status: duplicate Duplicate.
Projects
None yet
Development

No branches or pull requests

1 participant