Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hapi@18 #1107

Closed
klon opened this issue Aug 24, 2019 · 1 comment · Fixed by #1108
Closed

Support hapi@18 #1107

klon opened this issue Aug 24, 2019 · 1 comment · Fixed by #1108
Assignees
@kjin
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@klon
Copy link

klon commented Aug 24, 2019 •
edited
Loading

It seems I get no traces using hapi@18.3.2. Could that be because it is yet to be supported?
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Aug 25, 2019
@kjin
Copy link
Contributor

kjin commented Aug 25, 2019

Yes, we didn't update the version range to include 18 yet. It seems also like the module name changed, so I'll see if I can fix both of these issues.

@kjin kjin added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Aug 25, 2019
@kjin kjin self-assigned this Aug 25, 2019
@kjin kjin mentioned this issue Aug 26, 2019
Merged
3 tasks
@kjin kjin closed this as completed in #1108 Sep 3, 2019
@google-cloud-label-sync google-cloud-label-sync bot added the api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kjin kjin

Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support @hapi/hapi kjin/cloud-trace-nodejs
3 participants
@kjin @klon @yoshi-automation