Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @google-cloud/datastore to v4 #1028

Merged
merged 2 commits into from
May 16, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 15, 2019

This PR contains the following updates:

Package Type Update Change References
@​google-cloud/datastore dependencies major ^3.0.0 -> ^4.0.0 source

Release Notes

googleapis/nodejs-datastore

v4.0.0

Compare Source

Bug Fixes
Build System
BREAKING CHANGES
  • upgrade engines field to >=8.10.0 (#​388)

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 15, 2019
@bcoe bcoe assigned callmehiphop and unassigned callmehiphop May 15, 2019
@bcoe
Copy link
Contributor

bcoe commented May 15, 2019

@kjin looks like our update to datastore is causing some issues with TypeScript definitions; any thoughts?

@kjin
Copy link
Contributor

kjin commented May 15, 2019

@bcoe I don't think it's because of this change -- I also witnessed (and fixed) the issue in #1027. Once that's merged this should be good to go.

@renovate
Copy link
Contributor Author

renovate bot commented May 16, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@kjin kjin force-pushed the renovate/google-cloud-datastore-4.x branch from 3c2efe0 to f1855f6 Compare May 16, 2019 18:22
@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #1028 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1028   +/-   ##
=======================================
  Coverage   94.89%   94.89%           
=======================================
  Files          96       96           
  Lines        6226     6226           
  Branches      484      484           
=======================================
  Hits         5908     5908           
  Misses        161      161           
  Partials      157      157

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b37aa3d...f1855f6. Read the comment docs.

@kjin kjin merged commit c63bb14 into master May 16, 2019
@renovate renovate bot deleted the renovate/google-cloud-datastore-4.x branch May 16, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants