From 67f6c67621da9f8d3b795ee5ff4f63b65ff25d05 Mon Sep 17 00:00:00 2001 From: Matt Loring Date: Wed, 13 Jan 2016 12:21:09 -0800 Subject: [PATCH] Cleanup todos --- lib/cls.js | 5 ++--- lib/trace-labels.js | 3 --- lib/trace-span.js | 2 -- lib/trace-writer.js | 2 -- lib/trace.js | 2 -- 5 files changed, 2 insertions(+), 12 deletions(-) diff --git a/lib/cls.js b/lib/cls.js index fed05244b..71ba14b24 100644 --- a/lib/cls.js +++ b/lib/cls.js @@ -42,10 +42,9 @@ module.exports = { getNamespace: getNamespace, getRootContext: function getRootContext() { - // TODO: First getNamespace check is necessary in case any + // First getNamespace check is necessary in case any // patched closures escaped before the agent was stopped and the - // namespace was destroyed. There should be a cleaner way to - // avoid this (only collect traces once we have a project num) + // namespace was destroyed. if (getNamespace() && getNamespace().get('root')) { return getNamespace().get('root'); } diff --git a/lib/trace-labels.js b/lib/trace-labels.js index fb9b579e3..787736d31 100644 --- a/lib/trace-labels.js +++ b/lib/trace-labels.js @@ -16,9 +16,6 @@ 'use strict'; -// TODO(ofrobots): replace this file with the protobuf -// c.f. trace/proto/span_details.proto - /** * Well-known trace span label values. */ diff --git a/lib/trace-span.js b/lib/trace-span.js index 09eb97e4b..8345cdb25 100644 --- a/lib/trace-span.js +++ b/lib/trace-span.js @@ -16,8 +16,6 @@ 'use strict'; -// TODO(ofrobots): replace this file with the protobuf - /** * Creates a trace span object. * @constructor diff --git a/lib/trace-writer.js b/lib/trace-writer.js index 2d87e1095..87aa7601a 100644 --- a/lib/trace-writer.js +++ b/lib/trace-writer.js @@ -208,8 +208,6 @@ TraceWriter.prototype.publish_ = function(projectId, json) { headers: headers }, function(err, response, body) { if (err) { - // TODO(ofrobots): If we failed to publish due to a permanent error, stop - // the agent. that.logger_.error('TraceWriter: error: ', (response && response.statusCode) || '', err); } else { diff --git a/lib/trace.js b/lib/trace.js index 320b7702f..d69eab3d3 100644 --- a/lib/trace.js +++ b/lib/trace.js @@ -16,8 +16,6 @@ 'use strict'; -// TODO(ofrobots): replace this file with the protobuf - /** * Creates a trace object. * @constructor