From f7da411fcb7fe777cdbf13ae26c6a427035931bc Mon Sep 17 00:00:00 2001 From: Dominic Kramer Date: Wed, 13 Feb 2019 14:07:40 -0800 Subject: [PATCH 1/2] chore: add missing dev dependency --- package.json | 7 ++++--- test/auth-request.ts | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 49d02afb..0162247a 100644 --- a/package.json +++ b/package.json @@ -36,9 +36,10 @@ "@types/p-limit": "^2.0.0", "@types/pify": "^3.0.2", "@types/proxyquire": "^1.3.28", - "@types/request": "^2.47.1", + "@types/request": "^2.48.1", "@types/semver": "^5.3.32", "@types/uuid": "^3.4.4", + "broken-link-checker-local": "^0.2.0", "changelog-maker": "^2.2.2", "codecov": "^3.0.4", "cross-env": "^5.2.0", @@ -52,11 +53,11 @@ "nyc": "^13.1.0", "post-install-check": "0.0.1", "proxyquire": "^2.0.0", + "request": "^2.88.0", "require-inject": "^1.4.3", "source-map-support": "^0.5.6", "typescript": "~3.3.0", - "uuid": "^3.3.2", - "broken-link-checker-local": "^0.2.0" + "uuid": "^3.3.2" }, "dependencies": { "@google-cloud/common": "^0.27.0", diff --git a/test/auth-request.ts b/test/auth-request.ts index ef02ba08..4952d2e7 100644 --- a/test/auth-request.ts +++ b/test/auth-request.ts @@ -14,7 +14,7 @@ * limitations under the License. */ -import * as request from 'request'; // types only +import * as request from 'request'; export function authRequest(options: (request.UriOptions&request.CoreOptions)|( request.UrlOptions & request.CoreOptions)): Promise { From b33b9f7084f41d7581d80f320180c76d43a54b6d Mon Sep 17 00:00:00 2001 From: Dominic Kramer Date: Thu, 14 Feb 2019 13:08:51 -0800 Subject: [PATCH 2/2] provide a service context to avoid nocking --- test/fixtures/fib.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/fixtures/fib.js b/test/fixtures/fib.js index 3ef59ad5..e7f3afa9 100644 --- a/test/fixtures/fib.js +++ b/test/fixtures/fib.js @@ -32,6 +32,10 @@ var debuglet = require('../../..').start({ breakpointUpdateIntervalSec: 1, testMode_: true, allowExpressions: true + }, + serviceContext: { + service: 'cloud-debug-system-test-service', + version: 'unversioned' } });