Warn if malformed source-contexts is found

googleapis · Jan 14, 2016 · 3fcc8fa · 3fcc8fa
1 parent a782875
commit 3fcc8fa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/lib/debuglet.js b/lib/debuglet.js
@@ -102,7 +102,7 @@ Debuglet.prototype.start = function() {
 
       that.logger_.info('Unique ID for this Application: ' + id);
 
-      that.debugletApi_.init(id, function(err) {
+      that.debugletApi_.init(id, that.logger_, function(err) {
         if (err) {
           that.logger_.error('Unable to initialize the debuglet api' +
             ' -- disabling debuglet', err);

diff --git a/lib/debugletapi.js b/lib/debugletapi.js
@@ -58,9 +58,10 @@ function DebugletApi() {
  * that it can be uniquely identified on the server.
  * @param {!string} uid unique identifier for the version of source loaded
  *     in the client
+ * @param {Logger} logger a logger
  * @param {!function(?Error)} callback
  */
-DebugletApi.prototype.init = function(uid, callback) {
+DebugletApi.prototype.init = function(uid, logger, callback) {
   var that = this;
   that.uid_ = uid;
   that.nextWaitToken_ = null;
@@ -76,7 +77,7 @@ DebugletApi.prototype.init = function(uid, callback) {
       try {
         that.sourceContext_ = JSON.parse(data);
       } catch (e) {
-        // TODO: log a warning.
+        logger.warn('Malformed source-contexts.json file.');
         // But we keep on going.
       }
       callback(null);

diff --git a/test/test-debugletapi.js b/test/test-debugletapi.js
@@ -48,7 +48,7 @@ describe('Debuglet API', function() {
   });
 
   it('should acquire the project number during init', function(done) {
-    debugletapi.init('uid123', function(err) {
+    debugletapi.init('uid123', { warn: function() {} }, function(err) {
       assert(!err);
       done();
     });