fix(AIP-162): handle LRO in response name rules #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slevenick
approved these changes
Sep 20, 2024
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
🤖 I have created a release *beep* *boop* --- ## [1.67.3](https://togithub.com/googleapis/api-linter/compare/v1.67.2...v1.67.3) (2024-09-23) ### Bug Fixes * **AIP-132:** refine List request response regex ([#1420](https://togithub.com/googleapis/api-linter/issues/1420)) ([5cc4d27](https://togithub.com/googleapis/api-linter/commit/5cc4d279c9cfc80545a9d2447b4fe13a8032b2aa)) * **AIP-136:** ignore revision methods ([#1432](https://togithub.com/googleapis/api-linter/issues/1432)) ([a6ba5f3](https://togithub.com/googleapis/api-linter/commit/a6ba5f32458cefc42b662019d97199d0a8e86551)) * **AIP-162:** handle LRO in response name rules ([#1431](https://togithub.com/googleapis/api-linter/issues/1431)) ([8bca1dd](https://togithub.com/googleapis/api-linter/commit/8bca1dd68ccf00c39a06da9862ac8c599029297e)) * **internal/utils:** refine Get, Create, Update, Delete request regex ([#1422](https://togithub.com/googleapis/api-linter/issues/1422)) ([487328c](https://togithub.com/googleapis/api-linter/commit/487328ca8708521562be2921d3c4f2aabaf8a5ae)) * **locations:** make source info access concurrent safe ([#1433](https://togithub.com/googleapis/api-linter/issues/1433)) ([223aa5b](https://togithub.com/googleapis/api-linter/commit/223aa5bb6cf4f24193ad6c6037e1b88160474f2e)) ### Documentation * **AIP-132:** fix incorrect field for AIP-217 ([#1423](https://togithub.com/googleapis/api-linter/issues/1423)) ([6a52a68](https://togithub.com/googleapis/api-linter/commit/6a52a6845bf8f240a4d9f9a305a26609a2699c17)) * **AIP-134:** change mandated to recommended ([#1426](https://togithub.com/googleapis/api-linter/issues/1426)) ([338b6a9](https://togithub.com/googleapis/api-linter/commit/338b6a95906b61ba5a83805bce92919dd53725dc)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though AIP-162 is a bit in flux, the existing rules for it should be capable of handling an LRO i.e. when checking the response message name.
This updates all of the relevant rules to handle LRO RPC return types and load the message name from the operation_info annotation if applicable. Note: We cannot provide an actionable
Suggestionwhen the finding pertains to theoperation_infobecause we cannot accurately target theresponse_typefield.The same code is used consistently in a few places in this PR as well as in other rules. We may want to consider how we can centralize
Findingconstruction when it could be in the RPC return type section or theoperation_info.Internal bug http://b/367699275