Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AIP-123): skip resource-pattern-plural when there is no plural #1409

Merged
merged 2 commits into from
Jul 31, 2024
Merged

fix(AIP-123): skip resource-pattern-plural when there is no plural #1409

merged 2 commits into from
Jul 31, 2024

Conversation

noahdietz
Copy link
Collaborator

When there is no plural field in the google.api.resource, skip check if the plural exists in the pattern(s).

@noahdietz noahdietz requested a review from a team as a code owner July 31, 2024 20:15
@noahdietz noahdietz requested a review from itsStrobe July 31, 2024 21:51
@noahdietz noahdietz merged commit 93a601d into googleapis:main Jul 31, 2024
6 checks passed
@release-please release-please bot mentioned this pull request Jul 31, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 31, 2024
@release-please
chore(main): release 1.67.1 (#1410)
3085922 
🤖 I have created a release *beep* *boop*
---


## [1.67.1](https://togithub.com/googleapis/api-linter/compare/v1.67.0...v1.67.1) (2024-07-31)


### Bug Fixes

* **AIP-123:** skip resource-pattern-plural when there is no plural ([#1409](https://togithub.com/googleapis/api-linter/issues/1409)) ([93a601d](https://togithub.com/googleapis/api-linter/commit/93a601d92adbeb0c17fa8724212ee344f934a4aa))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsStrobe itsStrobe itsStrobe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noahdietz @itsStrobe