Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AIP-217): add various rules for return_partial_success support #1406

Merged
merged 8 commits into from
Jul 25, 2024

Conversation

noahdietz
Copy link
Collaborator

@noahdietz noahdietz commented Jul 17, 2024

Enforces some of the guidance in aip-dev/google.aip.dev#1385.

  • makes return_partial_success an allowed field for Standard List APIs
  • ensures return_partial_success is of type bool
  • ensures return_partial_success is added in presence of an unreachable response field

@noahdietz noahdietz marked this pull request as ready for review July 19, 2024 17:57
@noahdietz noahdietz requested a review from a team as a code owner July 19, 2024 17:57
@noahdietz noahdietz requested a review from itsStrobe July 24, 2024 19:33
@noahdietz noahdietz added automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit and removed automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Jul 24, 2024
@noahdietz noahdietz merged commit cf4ba12 into googleapis:main Jul 25, 2024
6 checks passed
@noahdietz noahdietz deleted the return-partial-success branch July 25, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants