Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AIP-136): request message name #1386

Merged
merged 2 commits into from
May 15, 2024
Merged

feat(AIP-136): request message name #1386

merged 2 commits into from
May 15, 2024

Conversation

liveFreeOrCode
Copy link
Contributor

AIP-136

Custom methods should take a request message matching the RPC name, with a Request suffix.

@liveFreeOrCode
feat: aip 0136 request message names
3253772 
This patch introduces a lint rule where all custom methods
should take a request message matching the RPC name, with
a Request suffix
@liveFreeOrCode liveFreeOrCode requested a review from a team as a code owner May 15, 2024 01:47
noahdietz
noahdietz approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff, just one comment. Thanks for this!

rules/aip0136/request_message_name_test.go Outdated Show resolved Hide resolved
@liveFreeOrCode
Copy link
Contributor Author

Awesome stuff, just one comment. Thanks for this!

No sweat, happy to contribute! I should have a PR up later for the response message name as well for these custom methods.

@noahdietz noahdietz added the automerge Summon MOG for automerging label May 15, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 46a6e43 into googleapis:main May 15, 2024
6 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label May 15, 2024
@release-please release-please bot mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liveFreeOrCode @noahdietz