Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor Standard Method message helpers into utils #1212

Merged
merged 7 commits into from
Jul 31, 2023

Conversation

noahdietz
Copy link
Collaborator

@noahdietz noahdietz commented Jul 28, 2023

All Standard Method request message Is{Method}(Request|Response)Message helpers moved into to utils and exported for other rules to use. This is also necessary for some internal rules.

Some already exported helpers in aip0162 are left behind, marked deprecated, and made to be passthroughs to the migrated methods. rules should not be importing eachother, it was probably not a good idea to export a function from a rule group package.

@noahdietz noahdietz marked this pull request as ready for review July 28, 2023 19:59
@noahdietz noahdietz requested a review from a team as a code owner July 28, 2023 19:59
@noahdietz noahdietz merged commit c6b5d10 into googleapis:main Jul 31, 2023
6 checks passed
@noahdietz noahdietz deleted the refactor-message-match branch July 31, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants