-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature suggestion: Provide Natively packaged version #251
Comments
Yes, this is easy to do. Will do it |
+1 |
Yea~~, |
I think it will not be a feature of zx. |
@antonmedv - I did some work on this a few weeks back, and have pushed a standalone / natively packaged build here: There are minimal changes to the existing code (it's mostly addition of some devDependencies, and a new build script; I've documented the changes in the code, and here: https://github.com/ejdaly/zx#fork-notes) The standalone build is feature-complete with the standard version (and passes all existing test cases). It is based on v4.3.0 however, but I'd be happy to attempt update to v5+ to see how that goes... If this is a feature you would consider as part of the main zx project - I'm happy to work with you to get this added. If not, that's fine too of course. Aside: I've also added a few other features to that branch (things I was interested in trying: dynamic import & REPL). I'm not suggesting here that those features be added to main repo (I see there are separate issues here for them; and I'll comment there...) |
Nice work! But I'm not thinking to add executable bins to zx right now. The first build process was error-prone and I completely removed it in v5. The second is security concerns. |
Sure, no problem at all. The build process is documented now in my fork - so people can follow that (or use the binaries directly..) if they have that use case... Out of interest, what security concerns would you see? Just the idea of running an unsigned / unverified binary? |
Yes, this and npm security checks now works really well. In case of a binary no one will be checking it for security holes. |
@antonmedv |
|
Yes, but |
I found when using the Bitwarden CLI that they provide a
natively packaged version
ofThis got me thinking that sometimes, maybe on some machines, I don't want to install
node
andnpm
, but would like to have a tool likezx
to help me execute scripts easilySo, it's helpful to provide a natively packaged version
Additional context:
The text was updated successfully, but these errors were encountered: