Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow concurrent, re-creatable usage #43

Closed
trabetti opened this issue Feb 27, 2019 · 4 comments
Closed

Allow concurrent, re-creatable usage #43

trabetti opened this issue Feb 27, 2019 · 4 comments

Comments

@trabetti
Copy link
Contributor

trabetti commented Feb 27, 2019

Hi, I am using this package to generate uuids for a test generator. I have a use case where multiple instances of the generator run asynchronously to create tests.
I need to be able to recreate failed tests, the current implementation holds only one seed, so there is no way to ensure recreation when processes are running asynchronously.
I have forked the repository and added a UuidSource, similar to a source in math/rand, which holds the rander, this solves my use case.
I suggest to do a PR from my fork.

@pborman
Copy link
Collaborator

pborman commented Feb 27, 2019

Sure, send me what you have.

@ahobson
Copy link

ahobson commented Aug 28, 2020

Any chance of a making a release with these changes?

@pborman
Copy link
Collaborator

pborman commented Aug 28, 2020

Oh, sorry! I will make release 1.2 now.

@pborman
Copy link
Collaborator

pborman commented Aug 28, 2020

Released as 1.1.2 (changes are too minor to be a 1.2 release). Thank you for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants