Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can there be a new release cut? #341

Closed
jherico opened this issue Jan 17, 2024 · 4 comments
Closed

Can there be a new release cut? #341

jherico opened this issue Jan 17, 2024 · 4 comments

Comments

@jherico
Copy link
Contributor

jherico commented Jan 17, 2024

I'm trying to get the vcpkg version of s2geometry updated so that it will build on windows, but the vcpkg maintainers don't want to accept an essentially random commit as a new build when this project already has a version history in vcpkg using tagged releases.

It seems like the google3 merge 9 months ago or anything subsequent to that would make a good spot for a version bump and a new build.

Thanks.

@jmr
Copy link
Member

jmr commented Jan 21, 2024

I'm working on integrating the latest Google changes, but tagging what we have sounds reasonable.

@jmr
Copy link
Member

jmr commented Jan 26, 2024

I merged #339. I'll let you update on your side and test it. Let me know if it's good to tag HEAD.

@jherico
Copy link
Contributor Author

jherico commented Jan 26, 2024

my branch of vcpkg now builds s2 successfully without any patches required, targeting the commit 5c2190ab374dcfa7467bd4894e4db6038e60a131. As soon as you tag it I can change the ref to the tag from the commit ID and update the vcpkg PR. Thanks.

@jmr
Copy link
Member

jmr commented Jan 27, 2024

@jmr jmr closed this as completed Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants