Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIFuzz] MSan not using its own zlib library #5873

Closed
catenacyber opened this issue Jun 4, 2021 · 4 comments
Closed

[CIFuzz] MSan not using its own zlib library #5873

catenacyber opened this issue Jun 4, 2021 · 4 comments

Comments

@catenacyber
Copy link
Contributor

cc @jonathanmetzman
Reopening #4614

We get a false positive from CIFuzz with MSAN because of not using the MSAN-compiled zlib
See https://github.com/OISF/suricata/pull/6170/checks?check_run_id=2745368209

==12==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x180e10d in htp_gzip_decompressor_probe /src/suricata/libhtp/htp/htp_decompressors.c:61:25
@jonathanmetzman
Copy link
Contributor

Hi @catenacyber
We're actually a little unsure about the future of MSAN in OSS-Fuzz right now since MSAN isn't really supported on newer versions of ubuntu and we want to upgrade our docker images at some point.

Since I have limited cycles right now, I don't think I'm going to spend much time on MSAN for CIFuzz right now.

@maflcko
Copy link
Contributor

maflcko commented Jun 7, 2021

Is there further reading available about "MSAN isn't really supported on newer versions of ubuntu"?

@jonathanmetzman
Copy link
Contributor

Is there further reading available about "MSAN isn't really supported on newer versions of ubuntu"?

I need to write something on this. You're not the first to ask.
If everything goes as planned, I should send something out this week explaining why, since we are going to upgrade the ubuntu version soon (and also have to drop msan support for a lot of projects :-(

@jonathanmetzman
Copy link
Contributor

Closing this bug since I think it only makes sense in a world where OSS-Fuzz is providing prebuilt msan libraries, which it won't be doing anymore with #6180.
More details on this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants