Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binutils:fuzz_cxxfilt #3500

Closed
amodra opened this issue Mar 13, 2020 · 9 comments
Closed

binutils:fuzz_cxxfilt #3500

amodra opened this issue Mar 13, 2020 · 9 comments

Comments

@amodra
Copy link
Contributor

amodra commented Mar 13, 2020

This fuzz target is testing cplus_demangle, provided by libiberty/cplus-dem.c. libiberty is under control of the gcc project, not the binutils project. The mis-categorization means that reports won't be seen by people most able to do something about issues.

@DavidKorczynski
Copy link
Collaborator

Thank you for the info! I wrote that Fuzzer and will see if we can move it to a project that fuzzes gcc rather than binutils!

@DavidKorczynski
Copy link
Collaborator

DavidKorczynski commented Mar 14, 2020

Rather than adding a new project and separating the binutils and libiberty maintainers, it might be smarter to simply add a gcc contributor to the binutils options file, considering more targets within binutils may call libiberty? Could we get an opinion on this from one of the oss-fuzz maintainers (@Dor1s maybe?)

@Dor1s
Copy link
Contributor

Dor1s commented Mar 16, 2020

Separating the projects might be a better long term solution, assuming that we'd have more fuzzers and more activity/interest in future.

The alternative option of adding a gcc contributor to the auto_ccs field is super easy to do, so I'd suggest doing that anyway :)

@DavidKorczynski
Copy link
Collaborator

DavidKorczynski commented Mar 16, 2020

Since the preferred long-term solution is to separate them I thought we should do that now rather than later. I fixed it up so the cxxfilt is separated and added a new gcc project. Sent a mail to the gcc mailing list with information and am now waiting to hear if they are interested and which email we can use. Will do a PR when they confirm.

@JulianVolodia
Copy link
Contributor

JulianVolodia commented Apr 1, 2020

Hi @DavidKorczynski , how are you?

Could you tell me if that mailing list is open and freely accesible for example... for me? I looking for some projects to work on and gain knowledge ;) Appreciate any information. Thanks!

cc #402

@DavidKorczynski
Copy link
Collaborator

I fixed the project cpp demangler to be part of a gcc project rather than binutils, however, the maintainers do not seem to be interested in fuzzing the cpp demangler - in essence the bugs will not be fixed as written on the mailing list: http://gcc.1065356.n8.nabble.com/Integrating-GCC-with-oss-fuzz-td1672098.html#a1672299

@Dor1s how do we proceed here? With lack of interest it seems a waste of resources and peoples time - should I simply remove the cpp demangler (also from binutils since they do not care about it either) totally and then maybe update the thread here #402 ? Or should I go ahead and push a gcc project where the maintainers seem far from thrilled about it.

@Dor1s
Copy link
Contributor

Dor1s commented Apr 2, 2020

Unfortunately, it's better to avoid wasting time and other resources, if maintainers aren't interested.

@DavidKorczynski
Copy link
Collaborator

This issue can be closed now as the cxxfilt fuzzer has been removed.

@amodra
Copy link
Contributor Author

amodra commented Apr 27, 2020

Thank you, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants